Incorporating logging into Cast

media/cast/cast_environment.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/cast_environment.h"
 
 #include "base/logging.h"
 
 using base::TaskRunner;
 
 namespace media {
 namespace cast {
 
 CastEnvironment::CastEnvironment(
     base::TickClock* clock,
     scoped_refptr<TaskRunner> main_thread_proxy,
     scoped_refptr<TaskRunner> audio_encode_thread_proxy,
     scoped_refptr<TaskRunner> audio_decode_thread_proxy,
     scoped_refptr<TaskRunner> video_encode_thread_proxy,
-    scoped_refptr<TaskRunner> video_decode_thread_proxy)
+    scoped_refptr<TaskRunner> video_decode_thread_proxy,
+    bool enable_data_collection,
+    bool enable_uma_stats,
+    bool enable_tracing)
     : clock_(clock),
       main_thread_proxy_(main_thread_proxy),
       audio_encode_thread_proxy_(audio_encode_thread_proxy),
       audio_decode_thread_proxy_(audio_decode_thread_proxy),
       video_encode_thread_proxy_(video_encode_thread_proxy),
-      video_decode_thread_proxy_(video_decode_thread_proxy) {
+      video_decode_thread_proxy_(video_decode_thread_proxy),
+      logging_(new LoggingImpl(clock, main_thread_proxy,

[Alpha Left Google, 2013/11/14 00:29:24]

Use a separate method to start logging instead of doing it in the constructor.

[mikhal, 2013/11/14 17:42:31]

Don't see why.
On 2013/11/14 00:29:24, Alpha wrote:

+          enable_data_collection, enable_uma_stats, enable_tracing)) {
   DCHECK(main_thread_proxy) << "Main thread required";
 }
 
 CastEnvironment::~CastEnvironment() {}
 
 bool CastEnvironment::PostTask(ThreadId identifier,
                           const tracked_objects::Location& from_here,
                           const base::Closure& task) {
   scoped_refptr<TaskRunner> task_runner =
       GetMessageTaskRunnerForThread(identifier);
@@ skipping 18 matching lines @@
       return main_thread_proxy_;
     case CastEnvironment::AUDIO_ENCODER:
       return audio_encode_thread_proxy_;
     case CastEnvironment::AUDIO_DECODER:
       return audio_decode_thread_proxy_;
     case CastEnvironment::VIDEO_ENCODER:
       return video_encode_thread_proxy_;
     case CastEnvironment::VIDEO_DECODER:
       return video_decode_thread_proxy_;
     default:
-      NOTREACHED() << "Invalid Thread ID.";
+      NOTREACHED() << "Invalid Thread identifier";
       return NULL;
   }
 }
 
 bool CastEnvironment::CurrentlyOn(ThreadId identifier) {
   switch (identifier) {
     case CastEnvironment::MAIN:
       return main_thread_proxy_->RunsTasksOnCurrentThread();
     case CastEnvironment::AUDIO_ENCODER:
       return audio_encode_thread_proxy_->RunsTasksOnCurrentThread();
     case CastEnvironment::AUDIO_DECODER:
       return audio_decode_thread_proxy_->RunsTasksOnCurrentThread();
     case CastEnvironment::VIDEO_ENCODER:
       return video_encode_thread_proxy_->RunsTasksOnCurrentThread();
     case CastEnvironment::VIDEO_DECODER:
       return video_decode_thread_proxy_->RunsTasksOnCurrentThread();
     default:
-      NOTREACHED() << "Wrong thread identifier";
+      NOTREACHED() << "Invalid thread identifier";
       return false;
   }
 }
 
-base::TickClock* CastEnvironment::Clock() {
+base::TickClock* const CastEnvironment::Clock() const {
   return clock_;
 }
 
+LoggingImpl* const CastEnvironment::Logging() {
+  return logging_.get();

[Alpha Left Google, 2013/11/14 00:29:24]

Check that this accessor is called on the right thread. Or will caller of this
method post task to the main thread to access the LoggingImpl object?

[mikhal, 2013/11/14 17:42:31]

Added a dcheck
On 2013/11/14 00:29:24, Alpha wrote:

+}
+
 }  // namespace cast
 }  // namespace media