Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 68613004: Experimental parser: run lexer tests with make.*.check (Closed)

Created:
7 years, 1 month ago by ulan
Modified:
7 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Experimental parser: run lexer tests with make.*.check BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17735

Patch Set 1 : #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -24 lines) Patch
A test/lexer/code-load-eval.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
A + test/lexer/lexer.status View 1 chunk +2 lines, -1 line 0 comments Download
A + test/lexer/testcfg.py View 4 chunks +7 lines, -12 lines 0 comments Download
M tools/run-tests.py View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 1 month ago (2013-11-14 10:54:36 UTC) #1
dcarney
lgtm
7 years, 1 month ago (2013-11-14 10:57:12 UTC) #2
ulan
7 years, 1 month ago (2013-11-14 11:37:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698