Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 68523009: Also support smi in load-ICs. (Closed)

Created:
7 years, 1 month ago by Toon Verwaest
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Also support smi in load-ICs. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17756

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -31 lines) Patch
M src/arm/stub-cache-arm.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M src/ic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic.cc View 1 4 chunks +14 lines, -21 lines 0 comments Download
M src/ic-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/stub-cache.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 3 chunks +13 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 1 month ago (2013-11-13 19:53:28 UTC) #1
ulan
LGTM https://codereview.chromium.org/68523009/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): https://codereview.chromium.org/68523009/diff/1/src/ia32/stub-cache-ia32.cc#newcode3167 src/ia32/stub-cache-ia32.cc:3167: Label* smi_target = &miss; I think it would ...
7 years, 1 month ago (2013-11-14 14:52:11 UTC) #2
Toon Verwaest
7 years, 1 month ago (2013-11-14 16:37:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698