DevTools: Get rid of synchronous XHRs in the frontend code

Source/devtools/front_end/bindings/TempFile.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 window.requestFileSystem = window.requestFileSystem || window.webkitRequestFileSystem;
 
 /**
  * @constructor
- * @param {!string} dirPath
- * @param {!string} name
- * @param {!function(?WebInspector.TempFile)} callback
+ * @param {string} dirPath
+ * @param {string} name
+ * @param {function(?WebInspector.TempFile)} callback
  */
 WebInspector.TempFile = function(dirPath, name, callback)
 {
     this._fileEntry = null;
     this._writer = null;
 
     /**
      * @param {!FileSystem} fs
      * @this {WebInspector.TempFile}
      */
@@ skipping 66 matching lines @@
     function didClearTempStorage()
     {
         window.requestFileSystem(window.TEMPORARY, 10, didInitFs.bind(this), errorHandler);
     }
     WebInspector.TempFile._ensureTempStorageCleared(didClearTempStorage.bind(this));
 }
 
 WebInspector.TempFile.prototype = {
     /**
      * @param {!Array.<string>} strings
-     * @param {!function(boolean)} callback
+     * @param {function(boolean)} callback
      */
     write: function(strings, callback)
     {
         var blob = new Blob(strings, {type: 'text/plain'});
         this._writer.onerror = function(e)
         {
             WebInspector.console.error("Failed to write into a temp file: " + e.target.error.message);
             callback(false);
         }
         this._writer.onwriteend = function(e)
@@ skipping 79 matching lines @@
 
     remove: function()
     {
         if (this._fileEntry)
             this._fileEntry.remove(function() {});
     }
 }
 
 /**
  * @constructor
- * @param {!string} dirPath
- * @param {!string} name
+ * @param {string} dirPath
+ * @param {string} name
  */
 WebInspector.DeferredTempFile = function(dirPath, name)
 {
     this._chunks = [];
     this._tempFile = null;
     this._isWriting = false;
     this._finishCallback = null;
     this._finishedWriting = false;
     this._callsPendingOpen = [];
     this._pendingReads = [];
     new WebInspector.TempFile(dirPath, name, this._didCreateTempFile.bind(this));
 }
 
 WebInspector.DeferredTempFile.prototype = {
     /**
      * @param {!Array.<string>} strings
      */
     write: function(strings)
     {
         if (!this._chunks)
             return;
         if (this._finishCallback)
             throw new Error("No writes are allowed after close.");
         this._chunks.push.apply(this._chunks, strings);
         if (this._tempFile && !this._isWriting)
             this._writeNextChunk();
     },
 
     /**
-     * @param {!function(?WebInspector.TempFile)} callback
+     * @param {function(?WebInspector.TempFile)} callback
      */
     finishWriting: function(callback)
     {
         this._finishCallback = callback;
         if (this._finishedWriting)
             callback(this._tempFile);
         else if (!this._isWriting && !this._chunks.length)
             this._notifyFinished();
     },
 
@@ skipping 90 matching lines @@
         if (this._tempFile)
             this._tempFile.remove();
     }
 }
 
 /**
  * @constructor
  */
 WebInspector.TempStorageCleaner = function()
 {
-    this._worker = Runtime.startSharedWorker("temp_storage_shared_worker", "TempStorage");
-    this._worker.onerror = this._handleError.bind(this);
-    this._callbacks = [];
-    this._worker.port.onmessage = this._handleMessage.bind(this);
-    this._worker.port.onerror = this._handleError.bind(this);
+    Runtime.startSharedWorker("temp_storage_shared_worker", "TempStorage").then(this._init.bind(this)).done();
 }
 
 WebInspector.TempStorageCleaner.prototype = {
     /**
-     * @param {!function()} callback
+     * @param {!SharedWorker} worker
+     */
+    _init: function(worker)
+    {
+        this._worker = worker;
+        this._worker.onerror = this._handleError.bind(this);
+        this._callbacks = [];
+        this._worker.port.onmessage = this._handleMessage.bind(this);
+        this._worker.port.onerror = this._handleError.bind(this);
+    },
+
+    /**
+     * @param {function()} callback
      */
     ensureStorageCleared: function(callback)
     {
         if (this._callbacks)
             this._callbacks.push(callback);
         else
             callback();
     },
 
     _handleMessage: function(event)
@@ skipping 14 matching lines @@
     _notifyCallbacks: function()
     {
         var callbacks = this._callbacks;
         this._callbacks = null;
         for (var i = 0; i < callbacks.length; i++)
             callbacks[i]();
     }
 }
 
 /**
- * @param {!function()} callback
+ * @param {function()} callback
  */
 WebInspector.TempFile._ensureTempStorageCleared = function(callback)
 {
     if (!WebInspector.TempFile._storageCleaner)
         WebInspector.TempFile._storageCleaner = new WebInspector.TempStorageCleaner();
     WebInspector.TempFile._storageCleaner.ensureStorageCleared(callback);
 }