Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/android/shell/res/layout/chrome_shell_activity.xml

Issue 682883002: Introduce TintedImageButton class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/shell/res/layout/chrome_shell_activity.xml
diff --git a/chrome/android/shell/res/layout/chrome_shell_activity.xml b/chrome/android/shell/res/layout/chrome_shell_activity.xml
index 126527a901d5346fc6248231ff255bb005489817..69290d11d54d6890a2f3f7993039fde446463300 100644
--- a/chrome/android/shell/res/layout/chrome_shell_activity.xml
+++ b/chrome/android/shell/res/layout/chrome_shell_activity.xml
@@ -8,6 +8,7 @@
<org.chromium.chrome.shell.TabManager android:id="@+id/tab_manager"
xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:chrome="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical">
@@ -16,11 +17,14 @@
android:layout_height="wrap_content"
android:orientation="horizontal"
android:background="@drawable/progress">
- <ImageButton android:id="@+id/stop_reload_button"
+ <org.chromium.chrome.browser.widget.TintedImageButton
+ android:id="@+id/stop_reload_button"
android:layout_width="38dp"
android:layout_height="38dp"
- android:src="@drawable/btn_stop_normal"
- android:scaleType="center" />
+ android:src="@drawable/btn_toolbar_stop_loading_white_normal"
+ android:background="?android:attr/selectableItemBackground"
+ android:scaleType="center"
+ chrome:tint="@color/default_tint"/>
David Trainor- moved to gerrit 2014/10/27 23:58:59 Should we have a default button style that applies
<EditText android:id="@+id/url"
android:layout_width="0dp"
android:layout_height="wrap_content"
@@ -34,19 +38,23 @@
android:hint="@string/url_hint"
android:inputType="textUri"
android:imeOptions="actionGo|flagNoExtractUi" />
- <ImageButton android:id="@+id/tab_switcher"
+ <org.chromium.chrome.browser.widget.TintedImageButton
+ android:id="@+id/tab_switcher"
android:layout_width="38dp"
android:layout_height="38dp"
- android:src="@drawable/tab_switcher"
+ android:src="@drawable/btn_tabswitcher_white_normal"
android:background="?android:attr/selectableItemBackground"
android:scaleType="center"
- android:contentDescription="@null" />
- <ImageButton android:id="@+id/menu_button"
+ android:contentDescription="@null"
+ chrome:tint="@color/default_tint"/>
+ <org.chromium.chrome.browser.widget.TintedImageButton
+ android:id="@+id/menu_button"
android:layout_width="38dp"
android:layout_height="38dp"
- android:src="@drawable/btn_menu"
+ android:src="@drawable/btn_menu_white_normal"
android:background="?android:attr/selectableItemBackground"
- android:scaleType="center" />
+ android:scaleType="center"
+ chrome:tint="@color/default_tint"/>
</org.chromium.chrome.shell.ChromeShellToolbar>
<FrameLayout android:id="@+id/content_container"
android:layout_width="match_parent"

Powered by Google App Engine
This is Rietveld 408576698