Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 67613005: Move template instance check from Object to FunctionTemplateInfo::IsTemplateFor (Closed)

Created:
7 years, 1 month ago by Toon Verwaest
Modified:
7 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Move template instance check from Object to FunctionTemplateInfo::IsTemplateFor BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -33 lines) Patch
M src/api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -20 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 1 month ago (2013-11-19 13:32:45 UTC) #1
dcarney
lgtm
7 years, 1 month ago (2013-11-19 13:36:37 UTC) #2
Toon Verwaest
7 years, 1 month ago (2013-11-19 13:38:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698