Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: cc/debug/unittest_only_benchmark.cc

Issue 67563002: cc: Plumbing for impl thread micro benchmarks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: speculative fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/unittest_only_benchmark.h ('k') | cc/debug/unittest_only_benchmark_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/unittest_only_benchmark.cc
diff --git a/cc/debug/unittest_only_benchmark.cc b/cc/debug/unittest_only_benchmark.cc
index fbd9ddeb68fe9a7193309470bcb60e4e90e62c90..9c6b17699e312c2bffe9408ab94e9fb79a60540a 100644
--- a/cc/debug/unittest_only_benchmark.cc
+++ b/cc/debug/unittest_only_benchmark.cc
@@ -2,19 +2,54 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/values.h"
#include "cc/debug/unittest_only_benchmark.h"
+#include "base/bind.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "base/values.h"
+#include "cc/debug/unittest_only_benchmark_impl.h"
+
namespace cc {
UnittestOnlyBenchmark::UnittestOnlyBenchmark(scoped_ptr<base::Value> value,
const DoneCallback& callback)
- : MicroBenchmark(callback) {}
+ : MicroBenchmark(callback),
+ create_impl_benchmark_(false),
+ weak_ptr_factory_(this) {
+ if (!value)
+ return;
+
+ base::DictionaryValue* settings = NULL;
+ value->GetAsDictionary(&settings);
+ if (!settings)
+ return;
+
+ if (settings->HasKey("run_benchmark_impl"))
+ settings->GetBoolean("run_benchmark_impl", &create_impl_benchmark_);
+}
-UnittestOnlyBenchmark::~UnittestOnlyBenchmark() {}
+UnittestOnlyBenchmark::~UnittestOnlyBenchmark() {
+ weak_ptr_factory_.InvalidateWeakPtrs();
+}
void UnittestOnlyBenchmark::DidUpdateLayers(LayerTreeHost* host) {
NotifyDone(scoped_ptr<base::Value>());
}
+void UnittestOnlyBenchmark::RecordImplResults(scoped_ptr<base::Value> results) {
+ NotifyDone(results.Pass());
+}
+
+scoped_ptr<MicroBenchmarkImpl> UnittestOnlyBenchmark::CreateBenchmarkImpl(
+ scoped_refptr<base::MessageLoopProxy> origin_loop) {
+ if (!create_impl_benchmark_)
+ return make_scoped_ptr<MicroBenchmarkImpl>(NULL);
+
+ return scoped_ptr<MicroBenchmarkImpl>(new UnittestOnlyBenchmarkImpl(
+ origin_loop,
+ NULL,
+ base::Bind(&UnittestOnlyBenchmark::RecordImplResults,
+ weak_ptr_factory_.GetWeakPtr())));
+}
+
} // namespace cc
« no previous file with comments | « cc/debug/unittest_only_benchmark.h ('k') | cc/debug/unittest_only_benchmark_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698