Adding presubmit check for WeakPtrFactory in the code

PRESUBMIT_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import glob
 import json
 import os
 import re
 import subprocess
@@ skipping 395 matching lines @@
     self.assertTrue(':1 OS_WINDOWS' in errors[0])
     self.assertTrue('(did you mean OS_WIN?)' in errors[0])
 
   def testValidOSMacroNames(self):
     lines = ['#if defined(%s)' % m for m in PRESUBMIT._VALID_OS_MACROS]
     errors = PRESUBMIT._CheckForInvalidOSMacrosInFile(
         MockInputApi(), MockFile('some/path/foo_platform.cc', lines))
     self.assertEqual(0, len(errors))
 
 
+class InvalidWeakPtrOrderCheck(unittest.TestCase):
+  def testForValidWeakPtrOrderBeingLastMember(self):
+    mock_input_api = MockInputApi()
+    lines_h = ['#include "base/memory/weak_ptr.h"',
+               'class A {',
+               '  int a;',
+               '  float b;',
+               '  char c;',
+               '',
+               '  //WeakPtrFactory should be last one,',
+               '  //all the member variables should appear above it.',
+               '  base::WeakPtrFactory<A> weak_factory_;',
+               '};']
+    mock_file_h = MockFile('something.h', lines_h)
+    mock_input_api.files = [mock_file_h]
+    errors = PRESUBMIT._CheckForWeakPtrOrder(mock_input_api, MockOutputApi())
+    self.assertEqual(0, len(errors))
+
+  def testForValidWeakPtrOrderBeingMemberBeforeDisallowMacro(self):
+    mock_input_api = MockInputApi()
+    lines_h = ['#include "base/memory/weak_ptr.h"',
+               'class A {',
+               '  int a;',
+               '  float b;',
+               '  char c;',
+               '',
+               '  //WeakPtrFactory should be last one,',
+               '  //all the member variables should appear above it.',
+               '  base::WeakPtrFactory<A> weak_factory_;',
+               '  DISALLOW_COPY_AND_ASSIGN(A);',
+               '};']
+    mock_file_h = MockFile('something.h', lines_h)
+    mock_input_api.files = [mock_file_h]
+    errors = PRESUBMIT._CheckForWeakPtrOrder(mock_input_api, MockOutputApi())
+    self.assertEqual(0, len(errors))
+
+  def testForValidWeakPtrOrderNestedWeakPtrMember(self):
+    mock_input_api = MockInputApi()
+    lines_h = ['#include "base/memory/weak_ptr.h"',
+               'class A {',
+               '  int a;',
+               '  float b;',
+               '  char c;',
+               '',
+               '  //WeakPtrFactory should be last one,',
+               '  //all the member variables should appear above it.',
+               '  base::WeakPtrFactory<A> weak_factory_;',
+               '  base::WeakPtrFactory<A> weak_factory_1;',
+               '  DISALLOW_COPY_AND_ASSIGN(A);',
+               '};']
+    mock_file_h = MockFile('something.h', lines_h)
+    mock_input_api.files = [mock_file_h]
+    errors = PRESUBMIT._CheckForWeakPtrOrder(mock_input_api, MockOutputApi())
+    self.assertEqual(0, len(errors))
+
+  def testForInvalidWeakPtrOrderBeingFirstMember(self):
+    mock_input_api = MockInputApi()
+    lines_cc = ['#include "base/memory/weak_ptr.h"',
+                'class A {',
+                '  //WeakPtrFactory should be last one,',
+                '  //all the member variables should appear above it.',
+                '  base::WeakPtrFactory<A> weak_factory_;',
+                '',
+                '  int a;',
+                '  float b;',
+                '  char c;',
+                '',
+                '  DISALLOW_COPY_AND_ASSIGN(A);',
+                '};']
+    mock_file_cc = MockFile('something.cc', lines_cc)
+    mock_input_api.files = [mock_file_cc]
+    errors = PRESUBMIT._CheckForWeakPtrOrder(mock_input_api, MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+  def testForInvalidWeakPtrOrderBeingInMiddle(self):
+    mock_input_api = MockInputApi()
+    lines_cpp = ['#include "base/memory/weak_ptr.h"',
+                 'class A {',
+                 '  int a;',
+                 '  float b;',
+                 '',
+                 '  //WeakPtrFactory should be last one,',
+                 '  //all the member variables should appear above it.',
+                 '  base::WeakPtrFactory<A> weak_factory_;',
+                 '',
+                 '  char c;',
+                 '  long d;',
+                 '',
+                 '  //WeakPtrFactory should be last one,',
+                 '  //all the member variables should appear above it.',
+                 '  base::WeakPtrFactory<A> weak_factory_1;',
+                 '  DISALLOW_COPY_AND_ASSIGN(A);',
+                 '};']
+    mock_file_cpp = MockFile('something.cpp', lines_cpp)
+    mock_input_api.files = [mock_file_cpp]
+    errors = PRESUBMIT._CheckForWeakPtrOrder(mock_input_api, MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+  def testForInvalidWeakPtrOrderVaribleAfterWeakptr(self):
+    mock_input_api = MockInputApi()
+    lines_mm = ['#include "base/memory/weak_ptr.h"',
+                'class A {',
+                '  int a;',
+                '  float b;',
+                '',
+                '  //WeakPtrFactory should be last one,',
+                '  //all the member variables should appear above it.',
+                '  base::WeakPtrFactory<A> weak_factory_;',
+                '  char c;',
+                '  DISALLOW_COPY_AND_ASSIGN(A);',
+                '};']
+    mock_file_mm = MockFile('something.mm', lines_mm)
+    mock_input_api.files = [mock_file_mm]
+    errors = PRESUBMIT._CheckForWeakPtrOrder(mock_input_api, MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+  def testForInvalidWeakPtrOrderMultipleFiles(self):
+    mock_input_api = MockInputApi()
+    lines_cc = ['#include "base/memory/weak_ptr.h"',
+                'class B {',
+                '  //WeakPtrFactory should be last one,',
+                '  //all the member variables should appear above it.',
+                '  base::WeakPtrFactory<B> weak_factory_;',
+                '',
+                '  int a;',
+                '  float b;',
+                '  char c;',
+                '  DISALLOW_COPY_AND_ASSIGN(B);',
+                '};']
+    lines_cpp = ['#include "base/memory/weak_ptr.h"',
+                 'class C {',
+                 '  int a;',
+                 '  float b;',
+                 '',
+                 '  //WeakPtrFactory should be last one,',
+                 '  //all the member variables should appear above it.',
+                 '  base::WeakPtrFactory<C> weak_factory_;',
+                 '  char c;',
+                 '  DISALLOW_COPY_AND_ASSIGN(C);',
+                 '};']
+    lines_h = ['#include "base/memory/weak_ptr.h"',
+               'class A {',
+               '  int a;',
+               '  float b;',
+               '  char c;',
+               '',
+               '  //WeakPtrFactory should be last one,',
+               '  //all the member variables should appear above it.',
+               '  base::WeakPtrFactory<A> weak_factory_;',
+               '  DISALLOW_COPY_AND_ASSIGN(A);',
+               '};']
+    lines_mm = ['#include "base/memory/weak_ptr.h"',
+                'class D {',
+                '  int a;',
+                '  float b;',
+                '',
+                '  //WeakPtrFactory should be last one,',
+                '  //all the member variables should appear above it.',
+                '  base::WeakPtrFactory<D> weak_factory_;',
+                '  char c;',
+                '  long abc;',
+                '  DISALLOW_COPY_AND_ASSIGN(D);',
+                '};']
+    mock_file_cc = MockFile('something.cc', lines_cc)
+    mock_file_cpp = MockFile('something.cpp', lines_cpp)
+    mock_file_h = MockFile('something.h', lines_h)
+    mock_file_mm = MockFile('something.mm', lines_mm)
+    mock_input_api.files = [mock_file_cc,
+                            mock_file_cpp,
+                            mock_file_h,
+                            mock_file_mm]
+    errors = PRESUBMIT._CheckForWeakPtrOrder(mock_input_api, MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+
 class InvalidIfDefinedMacroNamesTest(unittest.TestCase):
   def testInvalidIfDefinedMacroNames(self):
     lines = ['#if defined(TARGET_IPHONE_SIMULATOR)',
              '#if !defined(TARGET_IPHONE_SIMULATOR)',
              '#elif defined(TARGET_IPHONE_SIMULATOR)',
              '#ifdef TARGET_IPHONE_SIMULATOR',
              ' # ifdef TARGET_IPHONE_SIMULATOR',
              '# if defined(VALID) || defined(TARGET_IPHONE_SIMULATOR)',
              '# else  // defined(TARGET_IPHONE_SIMULATOR)',
              '#endif  // defined(TARGET_IPHONE_SIMULATOR)',]
@@ skipping 346 matching lines @@
     }
     for master, bots in bots.iteritems():
       for bot in bots:
         self.assertEqual(master, PRESUBMIT.GetTryServerMasterForBot(bot),
                          'bot=%s: expected %s, computed %s' % (
             bot, master, PRESUBMIT.GetTryServerMasterForBot(bot)))
 
 
 if __name__ == '__main__':
   unittest.main()