Added an iOS Device ninja build.

masters/master.chromium.fyi/master.cfg

 # vim: ft=python:
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from buildbot.changes import svnpoller
 from buildbot.scheduler import Dependent
 from buildbot.scheduler import Nightly
 from buildbot.scheduler import Periodic
 from buildbot.scheduler import Scheduler
@@ skipping 310 matching lines @@
 # ----------------------------------------------------------------------------
 # FACTORIES
 
 F = chromium_factory.ChromiumFactory
 def win(): return F('src/chrome', 'win32')
 def win_build(): return F('src/build', 'win32')
 def win_out(): return F('src/out', 'win32')
 def mac(): return F('src/xcodebuild', 'darwin')
 def linux(**kwargs): return F('src/out', 'linux2', **kwargs)
 def ios(): return F('src/xcodebuild', 'darwin')
+def mac_out(): return F('src/out', 'darwin')

[ghost stip (do not use), 2013/12/05 21:04:25]

I don't think you need this?

 
 def codesearch():
   return F('src/build', 'linux2', pull_internal=False, full_checkout=True,
            additional_svn_urls=[config.Master.trunk_url_tools])
 
 def codesearch_scheduler():
   return F('src/build', 'linux2', pull_internal=False)
 
 def chromeos():
   return F('src/build', 'linux2')
@@ skipping 970 matching lines @@
     factory_properties={
         'app_name': 'Chromium.app',
         'gclient_deps': 'ios',
         'gclient_env': {
             'GYP_DEFINES':
                 'component=static_library OS=ios chromium_ios_signing=0',
             'GYP_GENERATOR_FLAGS': 'xcode_project_version=3.2',
         },
     })
 
+f_chromium_rel_ninja_ios_device = ios().ChromiumFactory(
+  clobber=True,
+  # TODO(lliabraa): Need to upstream support for running tests on devices
+  # before we can actually run any tests.
+  tests=[],
+  options = ['--build-tool=ninja'],
+  factory_properties={
+    'app_name': 'Chromium.app',
+    'gclient_deps': 'ios',
+    'gclient_env': {
+      'GYP_CROSSCOMPILE': '1',
+      'GYP_GENERATORS': 'ninja',
+      'GYP_DEFINES': 'component=static_library OS=ios clang=1',
+      },
+    })
+
+
 f_chromium_linux_goma_canary = linux().ChromiumFactory(
     slave_type='BuilderTester',
     target='Release',
     options=['--compiler=goma'],
     factory_properties={
       'goma_canary': True,
       'slave_internal_url': config.Master.slave_internal_url,
     },
     tests=['diagnose_goma'])
 
@@ skipping 624 matching lines @@
   'auto_reboot': False,
 }
 
 b_chromium_rel_ios_device = {
   'name': 'Chromium iOS Device',
   'factory': f_chromium_rel_ios_device,
   'category': 'ios',
   'auto_reboot': False,
 }
 
+b_chromium_rel_ninja_ios_device = {
+  'name': 'Chromium iOS Device (ninja)',
+  'factory': f_chromium_rel_ninja_ios_device,
+  'category': 'ios',
+  'auto_reboot': False,
+}
+
 b_chromium_rel_linux_browser_valgrind_builder = {
   'name': 'Chromium Linux Browser Builder (valgrind)',
   'builddir': 'chromium-rel-linux-browser-valgrind-builder',
   'factory': f_chromium_rel_linux_browser_valgrind_builder,
   'category': 'valgrind',
   'auto_reboot': False,
 }
 
 b_chromium_windows_drmemory_builder = {
   'name': 'Windows Builder (DrMemory)',
@@ skipping 265 matching lines @@
   b_chromium_dbg_android_chromedriver_tests,
   b_chromium_dbg_android_asan_builder_tests,
   b_chromium_dbg_android_shared_jb_nexus7,
 
   # Android AOSP
   b_chromium_dbg_android_aosp_builder,
 
   # iOS
   b_chromium_dbg_ios_simulator,
   b_chromium_rel_ios_device,
+  b_chromium_rel_ninja_ios_device,
 
   # TSAN
   b_chromium_dbg_win_tsan,
   b_chromium_rel_linux_tsan_rv,
   b_chromium_rel_linux_tsan_v2,
 
   # LSan
   b_chromium_rel_linux_lsan_asan,
 
   # DrMemory
@@ skipping 63 matching lines @@
                                            config.Master.GetBotPassword())
 
 # Make sure everything works together.
 master_utils.VerifySetup(c, slaves)
 
 
 ####### STATUS TARGETS
 
 # Buildbot master url:
 # Must come before AutoSetupMaster().
-c['buildbotURL'] = 'http://build.chromium.org/p/chromium.fyi/'
+c['buildbotURL'] = ActiveMaster.buildbot_url

[ghost stip (do not use), 2013/12/05 21:04:25]

in general a good idea to make this change in a separate CL, but might as well
keep it here

[pgervais, 2013/12/05 21:44:13]

There are actually two of these modifications in that CL (another for
master.chromium.mac). What is the best way to do these modifications: do a
separate CL for each master (so it's easier to revert), or can we do several at
once?

 
 # Adds common status and tools to this master.
 master_utils.AutoSetupMaster(c, ActiveMaster,
     public_html="../master.chromium/public_html",
     templates=['../master.chromium/templates'],
     enable_http_status_push=ActiveMaster.is_production_host)
 
 # Add more.
 
 if STATUS_PUSH:
@@ skipping 60 matching lines @@
 
 c['status'].append(MailNotifier(
       fromaddr='ukai@chromium.org',  # Reply-To address
       mode='failing',
       categories=['goma'],
       relayhost=config.Master.smtp,
       subject='goma canary buildbot %(result)s in %(projectName)s '
               'on %(builder)s',
       extraRecipients=['goma+alert@google.com'],
       sendToInterestedUsers=False))