[Clean up] Move VariationsHttpHeaderProvider into a subdirectory.

[Clean up] Move VariationsHttpHeaderProvider into a subdirectory.

Along the way,
  * Tighten up //components/variations and //components/metrics DEPS.
  * Fix up metrics and variations BUILD.gn files.
  * Add unit test targets for metrics and variations.

BUG=420110
TEST=compiles
R=asvitkine@chromium.org
TBR=jochen@chromium.org, cbentzel@chromium.org

Committed: https://crrev.com/3be67db9b30c4fe4ca54f426361cb621f193a31b
Cr-Commit-Position: refs/heads/master@{#301060}

[Alexei Svitkine (slow), 2014-10-21 14:50:08]

You have check_deps failures on the bots.

[Ilya Sherman, 2014-10-22 00:22:20]

On 2014/10/21 14:50:08, Alexei Svitkine wrote:
> You have check_deps failures on the bots.

Feexed.

[Alexei Svitkine (slow), 2014-10-22 14:04:26]

https://chromiumcodereview.appspot.com/668863002/diff/60001/components/variat...
File components/variations/net/BUILD.gn (right):

https://chromiumcodereview.appspot.com/668863002/diff/60001/components/variat...
components/variations/net/BUILD.gn:16: "//components/variations/proto",
Shouldn't this also depend on //components/google_core_browser like it does in
the gypi file?

[Ilya Sherman, 2014-10-22 23:57:43]

https://chromiumcodereview.appspot.com/668863002/diff/60001/components/variat...
File components/variations/net/BUILD.gn (right):

https://chromiumcodereview.appspot.com/668863002/diff/60001/components/variat...
components/variations/net/BUILD.gn:16: "//components/variations/proto",
On 2014/10/22 14:04:26, Alexei Svitkine wrote:
> Shouldn't this also depend on //components/google_core_browser like it does in
> the gypi file?

Good catch!  Done.  (I wish the build would actually fail if dependencies like
this were missing... there's still so much mystery in our build files :/)

[Alexei Svitkine (slow), 2014-10-23 15:20:18]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2014-10-23 15:20:19]

lgtm

[commit-bot: I haz the power, 2014-10-23 15:21:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668863002/80001

[commit-bot: I haz the power, 2014-10-23 15:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 15:27:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ilya Sherman, 2014-10-23 22:39:45]

isherman@chromium.org changed reviewers:
+ cbentzel@chromium.org, jamesr@chromium.org, jochen@chromium.org

[Ilya Sherman, 2014-10-23 22:39:58]

+jamesr for all BUILD.gn changes.

TBR jochen for trivial changes to //chrome/*, //components/omnibox/*, and
//components/suggestions/*.
TBR cbentzel for moved //components/variations/net/DEPS dependency on //net.

[jamesr, 2014-10-23 22:43:24]

I don't have OWNERS for any of these BUILD.gn files

[Ilya Sherman, 2014-10-23 22:59:04]

On 2014/10/23 22:43:24, jamesr wrote:
> I don't have OWNERS for any of these BUILD.gn files

I've TBR'ed OWNERS, but I was hoping you could double-check my GN-foo, which I
am still learning.

[jamesr, 2014-10-24 00:30:05]

BUILD.gn lgtm with one comment.

https://codereview.chromium.org/668863002/diff/80001/components/variations/ne...
File components/variations/net/BUILD.gn (right):

https://codereview.chromium.org/668863002/diff/80001/components/variations/ne...
components/variations/net/BUILD.gn:5: source_set("variations_http_provider") {
this is very stuttery for a GN label. source_set names do not have to be
globally unique, only their label needs to be. the label for this is

//components/variations/net:variations_http_provider

which repeats variations.  If that's the only thing that this directory will
contain, i would call this source_set "net" making the label

//components/variations/net

or if you will have things other than the http provider, call it something like

//components/variations/net:http_provider

https://codereview.chromium.org/668863002/diff/80001/components/variations/ne...
components/variations/net/BUILD.gn:11: public_deps = [
collapse this to one line:

public_deps = [ "//components/variations" ]

[Ilya Sherman, 2014-10-24 00:44:45]

Thanks, James :)

https://codereview.chromium.org/668863002/diff/80001/components/variations/ne...
File components/variations/net/BUILD.gn (right):

https://codereview.chromium.org/668863002/diff/80001/components/variations/ne...
components/variations/net/BUILD.gn:5: source_set("variations_http_provider") {
On 2014/10/24 00:30:05, jamesr wrote:
> this is very stuttery for a GN label. source_set names do not have to be
> globally unique, only their label needs to be. the label for this is
> 
> //components/variations/net:variations_http_provider
> 
> which repeats variations.  If that's the only thing that this directory will
> contain, i would call this source_set "net" making the label
> 
> //components/variations/net
> 
> or if you will have things other than the http provider, call it something
like
> 
> //components/variations/net:http_provider

Done.  I originally chose the name to match the GYP target name, but I agree
with you that it's pretty clunky.

https://codereview.chromium.org/668863002/diff/80001/components/variations/ne...
components/variations/net/BUILD.gn:11: public_deps = [
On 2014/10/24 00:30:05, jamesr wrote:
> collapse this to one line:
> 
> public_deps = [ "//components/variations" ]

Done.

[Ilya Sherman, 2014-10-24 00:49:23]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-24 00:51:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668863002/100001

[commit-bot: I haz the power, 2014-10-24 01:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:04:48]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2014-10-24 01:25:25]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:27:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668863002/120001

[commit-bot: I haz the power, 2014-10-24 01:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:39:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ilya Sherman, 2014-10-24 05:02:25]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-24 05:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668863002/140001

[commit-bot: I haz the power, 2014-10-24 05:57:52]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2014-10-24 05:58:43]

Patchset 8 (id:??) landed as
https://crrev.com/3be67db9b30c4fe4ca54f426361cb621f193a31b
Cr-Commit-Position: refs/heads/master@{#301060}