Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3731)

Unified Diff: chrome/browser/about_flags.cc

Issue 667183002: Add --ssl-version-min and --ssl-version-fallback-min to chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Joao's comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index f040401a3f49ea33b8ace1e2c2af85337cb200a7..8bc92188465fc9dc786f86c8a3cc134a465c995e 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -477,6 +477,30 @@ const Experiment::Choice kAutofillSyncCredentialChoices[] = {
password_manager::switches::kDisallowAutofillSyncCredential, ""},
};
+const Experiment::Choice kSSLVersionMinChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_SSL_VERSION_MIN_SSL3,
+ switches::kSSLVersionMin, "ssl3" },
+ { IDS_SSL_VERSION_MIN_TLS1,
+ switches::kSSLVersionMin, "tls1" },
+ { IDS_SSL_VERSION_MIN_TLS1_1,
+ switches::kSSLVersionMin, "tls1.1" },
+ { IDS_SSL_VERSION_MIN_TLS1_2,
+ switches::kSSLVersionMin, "tls1.2" },
+};
+
+const Experiment::Choice kSSLVersionFallbackMinChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_SSL_VERSION_MIN_SSL3,
+ switches::kSSLVersionFallbackMin, "ssl3" },
+ { IDS_SSL_VERSION_MIN_TLS1,
+ switches::kSSLVersionFallbackMin, "tls1" },
+ { IDS_SSL_VERSION_MIN_TLS1_1,
+ switches::kSSLVersionFallbackMin, "tls1.1" },
+ { IDS_SSL_VERSION_MIN_TLS1_2,
+ switches::kSSLVersionFallbackMin, "tls1.2" },
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1968,6 +1992,20 @@ const Experiment kExperiments[] = {
SINGLE_VALUE_TYPE(extensions::switches::kEnableRemoteAssistance)
},
#endif // defined(OS_CHROMEOS)
+ {
+ "ssl-version-min",
+ IDS_FLAGS_SSL_VERSION_MIN_NAME,
+ IDS_FLAGS_SSL_VERSION_MIN_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kSSLVersionMinChoices)
+ },
+ {
+ "ssl-version-fallback-min",
+ IDS_FLAGS_SSL_VERSION_FALLBACK_MIN_NAME,
+ IDS_FLAGS_SSL_VERSION_FALLBACK_MIN_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kSSLVersionFallbackMinChoices)
+ }
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698