src/lithium.cc - Issue 66693002: Do not add values to HGraph in Lithium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lithium.cc

Issue 66693002: Do not add values to HGraph in Lithium. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lithium.cc

diff --git a/src/lithium.cc b/src/lithium.cc

index 1be4b0654bbba424980c629f611d33c212ee99f4..7b902e2492a6ebe4f7e11d1014d630e1d9bee62f 100644

--- a/src/lithium.cc

+++ b/src/lithium.cc

@@ -423,6 +423,7 @@ LChunk* LChunk::NewChunk(HGraph* graph) {

DisallowHandleAllocation no_handles;

DisallowHeapAllocation no_gc;

int values = graph->GetMaximumValueID();

+ graph->DisallowAddingNewValues();

Toon Verwaest 2013/11/08 13:32:21 I'd swap the 2 lines above, just in the case someo

CompilationInfo* info = graph->info();

if (values > LUnallocated::kMaxVirtualRegisters) {

info->set_bailout_reason(kNotEnoughVirtualRegistersForValues);

« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »