Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: src/lithium.cc

Issue 66693002: Do not add values to HGraph in Lithium. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 Representation LChunk::LookupLiteralRepresentation( 416 Representation LChunk::LookupLiteralRepresentation(
417 LConstantOperand* operand) const { 417 LConstantOperand* operand) const {
418 return graph_->LookupValue(operand->index())->representation(); 418 return graph_->LookupValue(operand->index())->representation();
419 } 419 }
420 420
421 421
422 LChunk* LChunk::NewChunk(HGraph* graph) { 422 LChunk* LChunk::NewChunk(HGraph* graph) {
423 DisallowHandleAllocation no_handles; 423 DisallowHandleAllocation no_handles;
424 DisallowHeapAllocation no_gc; 424 DisallowHeapAllocation no_gc;
425 int values = graph->GetMaximumValueID(); 425 int values = graph->GetMaximumValueID();
426 graph->DisallowAddingNewValues();
Toon Verwaest 2013/11/08 13:32:21 I'd swap the 2 lines above, just in the case someo
426 CompilationInfo* info = graph->info(); 427 CompilationInfo* info = graph->info();
427 if (values > LUnallocated::kMaxVirtualRegisters) { 428 if (values > LUnallocated::kMaxVirtualRegisters) {
428 info->set_bailout_reason(kNotEnoughVirtualRegistersForValues); 429 info->set_bailout_reason(kNotEnoughVirtualRegistersForValues);
429 return NULL; 430 return NULL;
430 } 431 }
431 LAllocator allocator(values, graph); 432 LAllocator allocator(values, graph);
432 LChunkBuilder builder(info, graph, &allocator); 433 LChunkBuilder builder(info, graph, &allocator);
433 LChunk* chunk = builder.Build(); 434 LChunk* chunk = builder.Build();
434 if (chunk == NULL) return NULL; 435 if (chunk == NULL) return NULL;
435 436
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 500
500 501
501 LPhase::~LPhase() { 502 LPhase::~LPhase() {
502 if (ShouldProduceTraceOutput()) { 503 if (ShouldProduceTraceOutput()) {
503 isolate()->GetHTracer()->TraceLithium(name(), chunk_); 504 isolate()->GetHTracer()->TraceLithium(name(), chunk_);
504 } 505 }
505 } 506 }
506 507
507 508
508 } } // namespace v8::internal 509 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698