chrome/browser/android/chrome_web_contents_delegate_android.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_web_contents_delegate_android.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/chrome_web_contents_delegate_android.cc

diff --git a/chrome/browser/android/chrome_web_contents_delegate_android.cc b/chrome/browser/android/chrome_web_contents_delegate_android.cc

index 64630833b947c5db165df67e969ce8a27b9e5aa0..5da8e49bcc579564933ee0e24cb7803496ac8d9c 100644

--- a/chrome/browser/android/chrome_web_contents_delegate_android.cc

+++ b/chrome/browser/android/chrome_web_contents_delegate_android.cc

@@ -15,13 +15,13 @@

#include "chrome/browser/prerender/prerender_manager.h"

#include "chrome/browser/prerender/prerender_manager_factory.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h"

#include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/find_bar/find_notification_details.h"

#include "chrome/browser/ui/find_bar/find_tab_helper.h"

#include "chrome/browser/ui/tab_helpers.h"

#include "chrome/common/chrome_switches.h"

+#include "components/app_modal_dialogs/javascript_dialog_manager.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

« no previous file with comments | « chrome/browser/DEPS ('k') | chrome/browser/chrome_browser_main.cc » ('j') | chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm » ('J')