chrome/browser/BUILD.gn - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index b118e85083ab74e50187359ac293260c31022134..970237253c282c6b5e5f2f2600019730067e0cad 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -167,6 +167,7 @@ static_library("browser") {

"//cc",

"//chrome/browser/devtools",

"//chrome/installer/util",

+ "//components/app_modal_dialogs",

"//components/autofill/content/browser",

"//components/dom_distiller/content",

"//components/keyed_service/content",

@@ -264,6 +265,7 @@ static_library("browser") {

"//chrome/browser/sync_file_system/drive_backend:sync_file_system_drive_proto",

"//chrome/common/extensions/api",

"//chrome/common/extensions/api:api_registration",

+ "//extensions/components/javascript_dialog_extensions_client",

]

sources += rebase_path(gypi_values.chrome_browser_extensions_sources,

".", "//chrome")

« no previous file with comments | « no previous file | chrome/browser/DEPS » ('j') | chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm » ('J')