extensions/components/javascript_dialog_extensions_client.gypi - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/components/javascript_dialog_extensions_client.gypi

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm ('K') | « extensions/components/extensions_components.gyp ('k') | extensions/components/javascript_dialog_extensions_client/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'targets': [	5 'targets': [

6 {	6 {

7 'target_name': 'native_app_window',	7 'target_name': 'javascript_dialog_extensions_client',

8 'type': 'static_library',	8 'type': 'static_library',

9 'dependencies': [	9 'dependencies': [

10 '../../base/base.gyp:base',	10 '../../components/components.gyp:app_modal_dialogs',

11 '../../content/content.gyp:content_browser',

12 '../../skia/skia.gyp:skia',	11 '../../skia/skia.gyp:skia',

13 '../../ui/views/views.gyp:views',

14 '../../ui/views/controls/webview/webview.gyp:webview',

15 '../extensions.gyp:extensions_browser',	12 '../extensions.gyp:extensions_browser',

16 '../extensions.gyp:extensions_common',	13 '../extensions.gyp:extensions_common',

17 ],	14 ],

18 'include_dirs': [	15 'include_dirs': [

19 '../..',	16 '../..',

20 ],	17 ],

21 'sources': [	18 'sources': [

22 'native_app_window/native_app_window_views.cc',	19 'javascript_dialog_extensions_client/javascript_dialog_extension_client_ impl.cc',

23 'native_app_window/native_app_window_views.h',	20 'javascript_dialog_extensions_client/javascript_dialog_extension_client_ impl.h',

24 ],	21 ],

25 },	22 },

26 ],	23 ],

27 }	24 }

OLD	NEW