chrome/browser/DEPS - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/DEPS

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/android/chrome_web_contents_delegate_android.cc » ('j') | chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+apps",	2 "+apps",

3 "+ash",	3 "+ash",

4 "+athena/content/public",	4 "+athena/content/public",

5 "+chrome/app",	5 "+chrome/app",

6 "+chrome/grit", # For generated headers	6 "+chrome/grit", # For generated headers

7 "+chrome/installer",	7 "+chrome/installer",

8 "+chrome_elf/blacklist",	8 "+chrome_elf/blacklist",

9 "+chrome_elf/chrome_elf_constants.h",	9 "+chrome_elf/chrome_elf_constants.h",

10 "+chrome_elf/create_file",	10 "+chrome_elf/create_file",

(...skipping 71 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 "+content/public/browser",	82 "+content/public/browser",

83 "+content/test/net",	83 "+content/test/net",

84 "+courgette",	84 "+courgette",

85 "+device/bluetooth",	85 "+device/bluetooth",

86 "+device/core",	86 "+device/core",

87 "+device/hid",	87 "+device/hid",

88 "+device/usb",	88 "+device/usb",

89 "+device/media_transfer_protocol",	89 "+device/media_transfer_protocol",

90 "+extensions/browser",	90 "+extensions/browser",

91 "+extensions/common",	91 "+extensions/common",

	92 "+extensions/components/javascript_dialog_extensions_client",

92 "+extensions/grit",	93 "+extensions/grit",

93 "+extensions/test",	94 "+extensions/test",

94 "+google/cacheinvalidation", # Sync invalidation API protobuf files.	95 "+google/cacheinvalidation", # Sync invalidation API protobuf files.

95 "+google_apis",	96 "+google_apis",

96 "+google_update",	97 "+google_update",

97 "+grit", # TODO(thestig) Remove. For generated headers	98 "+grit", # TODO(thestig) Remove. For generated headers

98 "+installer_util_strings", # For generated headers	99 "+installer_util_strings", # For generated headers

99 "+jni",	100 "+jni",

100 "+media/base", # For media switches	101 "+media/base", # For media switches

101 "+policy", # For generated headers and source	102 "+policy", # For generated headers and source

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
160 "+third_party/WebKit/public/web/WebCache.h",	161 "+third_party/WebKit/public/web/WebCache.h",

161 "+third_party/WebKit/public/web/WebContextMenuData.h",	162 "+third_party/WebKit/public/web/WebContextMenuData.h",

162 "+third_party/WebKit/public/web/WebFindOptions.h",	163 "+third_party/WebKit/public/web/WebFindOptions.h",

163 "+third_party/WebKit/public/web/WebInputEvent.h",	164 "+third_party/WebKit/public/web/WebInputEvent.h",

164 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",	165 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",

165 "+third_party/WebKit/public/web/WebPageVisibilityState.h",	166 "+third_party/WebKit/public/web/WebPageVisibilityState.h",

166 "+third_party/WebKit/public/web/WebPluginAction.h",	167 "+third_party/WebKit/public/web/WebPluginAction.h",

167 "+third_party/WebKit/public/web/WebTextDirection.h",	168 "+third_party/WebKit/public/web/WebTextDirection.h",

168 "+third_party/WebKit/public/web/WebWindowFeatures.h",	169 "+third_party/WebKit/public/web/WebWindowFeatures.h",

169 ]	170 ]

OLD	NEW