Implement PushManager#hasPermission

chrome/browser/services/gcm/push_messaging_service_impl.h

Index: chrome/browser/services/gcm/push_messaging_service_impl.h
diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h
index 39d94c23aba367528a393719554b4d58d178a4d2..562042bfae6c4fdeb55a902aa1b7f9216144dcd9 100644
--- a/chrome/browser/services/gcm/push_messaging_service_impl.h
+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h
@@ -11,9 +11,13 @@
 #include "components/gcm_driver/gcm_client.h"
 #include "content/public/browser/push_messaging_service.h"
 #include "content/public/common/push_messaging_status.h"
+#include "third_party/WebKit/public/platform/WebPushPermissionCallback.h"
 
 class Profile;
 
+typedef blink::WebPushPermissionCallback::PushPermissionStatus

[Michael van Ouwerkerk, 2014/10/20 16:30:07]

That's a weird way of pulling in an enum. It should be in its own file, without
the callback.

[Miguel Garcia, 2014/10/22 16:35:27]

Done.

+    PushPermissionStatus;
+
 namespace user_prefs {
 class PrefRegistrySyncable;
 }
@@ -57,6 +61,9 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
       int render_frame_id,
       bool user_gesture,
       const content::PushMessagingService::RegisterCallback& callback) override;
+  virtual PushPermissionStatus PermissionStatus(

[Michael van Ouwerkerk, 2014/10/20 16:30:08]

This method should be be named as a verb e.g. GetPermissionStatus.

+      const GURL& requesting_origin, int renderer_id,
+      int render_frame_id) override;
 
  private:
   void DeliverMessageCallback(const PushMessagingApplicationId& application_id,