Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.h

Issue 661463002: Implement PushManager#hasPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Support all three possible states of the permission Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/push_messaging_service_impl.h
diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h
index 39d94c23aba367528a393719554b4d58d178a4d2..562042bfae6c4fdeb55a902aa1b7f9216144dcd9 100644
--- a/chrome/browser/services/gcm/push_messaging_service_impl.h
+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h
@@ -11,9 +11,13 @@
#include "components/gcm_driver/gcm_client.h"
#include "content/public/browser/push_messaging_service.h"
#include "content/public/common/push_messaging_status.h"
+#include "third_party/WebKit/public/platform/WebPushPermissionCallback.h"
class Profile;
+typedef blink::WebPushPermissionCallback::PushPermissionStatus
+ PushPermissionStatus;
mlamouri (slow - plz ping) 2014/10/16 09:04:57 Do we allow typedef's to be added in a header?
Miguel Garcia 2014/10/16 13:50:26 I see this all the time https://cs.corp.google.com
mlamouri (slow - plz ping) 2014/10/17 09:30:56 I see it being used inside classes or when a class
+
namespace user_prefs {
class PrefRegistrySyncable;
}
@@ -57,6 +61,9 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
int render_frame_id,
bool user_gesture,
const content::PushMessagingService::RegisterCallback& callback) override;
+ virtual PushPermissionStatus PermissionStatus(
+ const GURL& requesting_origin, int renderer_id,
+ int render_frame_id) override;
private:
void DeliverMessageCallback(const PushMessagingApplicationId& application_id,

Powered by Google App Engine
This is Rietveld 408576698