Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 661153003: Roll to Checkstyle 5.9 and enable Indentation check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/checkstyle/checkstyle.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/checkstyle/chromium-style-5.0.xml
diff --git a/tools/android/checkstyle/chromium-style-5.0.xml b/tools/android/checkstyle/chromium-style-5.0.xml
index 7f6b7ee06b0f93bdd6f519dc45c5c2406e819b6b..17b44b483d936e2d4f246af548c839993abb2023 100644
--- a/tools/android/checkstyle/chromium-style-5.0.xml
+++ b/tools/android/checkstyle/chromium-style-5.0.xml
@@ -158,11 +158,11 @@
<property name="option" value="top"/>
<property name="separated" value="true"/>
</module>
- <!-- TODO(aurimas): make indentation an error once https://github.com/checkstyle/checkstyle/issues/255 is fixed. -->
<module name="Indentation">
- <property name="severity" value="info"/>
+ <property name="severity" value="error"/>
<property name="basicOffset" value="4"/>
<property name="throwsIndent" value="8"/>
+ <property name="lineWrappingIndentation" value="8"/>
</module>
</module>
<module name="FileTabCharacter">
« no previous file with comments | « tools/android/checkstyle/checkstyle.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698