Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 66063002: Remove Win Aura bots from the buildbot and tryservers since they're now redundant as trunk Windows … (Closed)

Created:
7 years, 1 month ago by jam
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Remove Win Aura bots from the buildbot and tryservers since they're now redundant as trunk Windows is using Aura. BUG=316199 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=234668

Patch Set 1 #

Patch Set 2 : sync #

Total comments: 4

Patch Set 3 : update slaves.cfg #

Total comments: 4

Patch Set 4 : move to unused per stip #

Patch Set 5 : 80 cols #

Total comments: 2

Patch Set 6 : the real unused #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -182 lines) Patch
M masters/master.chromium.unused/slaves.cfg View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M masters/master.chromium.win/master_win_cfg.py View 1 4 chunks +3 lines, -75 lines 0 comments Download
M masters/master.chromium.win/slaves.cfg View 1 1 chunk +0 lines, -32 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 1 3 chunks +2 lines, -32 lines 0 comments Download
M masters/master.tryserver.chromium/slaves.cfg View 1 2 3 chunks +0 lines, -16 lines 0 comments Download
M masters/master.tryserver.unused/slaves.cfg View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M scripts/tools/lkgr_finder.py View 1 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jam
This is the removal part of win aura bots that was split off from https://codereview.chromium.org/64723003. ...
7 years, 1 month ago (2013-11-08 01:05:48 UTC) #1
jam
hey guys, looks like this is ready to land now?
7 years, 1 month ago (2013-11-12 16:07:30 UTC) #2
Paweł Hajdan Jr.
LGTM with comments. https://codereview.chromium.org/66063002/diff/40001/masters/master.chromium.win/master_win_cfg.py File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/66063002/diff/40001/masters/master.chromium.win/master_win_cfg.py#newcode403 masters/master.chromium.win/master_win_cfg.py:403: 'events', Is this addition intentional? https://codereview.chromium.org/66063002/diff/40001/masters/master.tryserver.chromium/master.cfg ...
7 years, 1 month ago (2013-11-12 18:54:59 UTC) #3
jam
https://codereview.chromium.org/66063002/diff/40001/masters/master.chromium.win/master_win_cfg.py File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/66063002/diff/40001/masters/master.chromium.win/master_win_cfg.py#newcode403 masters/master.chromium.win/master_win_cfg.py:403: 'events', On 2013/11/12 18:54:59, Paweł Hajdan Jr. wrote: > ...
7 years, 1 month ago (2013-11-12 19:00:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/66063002/40001
7 years, 1 month ago (2013-11-12 19:01:14 UTC) #5
commit-bot: I haz the power
Presubmit check for 66063002-40001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 1 month ago (2013-11-12 19:01:57 UTC) #6
jam
ptal to see the update to slaves.cfg which hopefully fixes the presubmit check
7 years, 1 month ago (2013-11-12 19:09:56 UTC) #7
ghost stip (do not use)
https://chromiumcodereview.appspot.com/66063002/diff/120001/masters/master.chromium.win/slaves.cfg File masters/master.chromium.win/slaves.cfg (left): https://chromiumcodereview.appspot.com/66063002/diff/120001/masters/master.chromium.win/slaves.cfg#oldcode362 masters/master.chromium.win/slaves.cfg:362: 'hostname': 'build60-m1', put these slaves in master.chromium.unused https://chromiumcodereview.appspot.com/66063002/diff/120001/masters/master.tryserver.chromium/slaves.cfg File ...
7 years, 1 month ago (2013-11-12 19:19:24 UTC) #8
jam
https://codereview.chromium.org/66063002/diff/120001/masters/master.chromium.win/slaves.cfg File masters/master.chromium.win/slaves.cfg (left): https://codereview.chromium.org/66063002/diff/120001/masters/master.chromium.win/slaves.cfg#oldcode362 masters/master.chromium.win/slaves.cfg:362: 'hostname': 'build60-m1', On 2013/11/12 19:19:24, stip wrote: > put ...
7 years, 1 month ago (2013-11-12 19:32:27 UTC) #9
ghost stip (do not use)
I think you meant master.chromium.unused instead of master.chromiumos.unused :) lg other than that https://chromiumcodereview.appspot.com/66063002/diff/250001/masters/master.chromiumos.unused/slaves.cfg File ...
7 years, 1 month ago (2013-11-12 20:06:48 UTC) #10
jam
On 2013/11/12 20:06:48, stip wrote: > I think you meant master.chromium.unused instead of master.chromiumos.unused :) ...
7 years, 1 month ago (2013-11-12 20:39:31 UTC) #11
ghost stip (do not use)
lgtm
7 years, 1 month ago (2013-11-13 00:11:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/66063002/290001
7 years, 1 month ago (2013-11-13 00:11:49 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 00:12:39 UTC) #14
Message was sent while issue was closed.
Change committed as 234668

Powered by Google App Engine
This is Rietveld 408576698