Fix Java indentation issues.

Fix Java indentation issues.

Fix indentation issue to allow enabling Checkstyle indentation rule.

BUG=318404
Committed: https://crrev.com/38aa15f1d56f69c0d2d265497ffeb6e8645e79ff
Cr-Commit-Position: refs/heads/master@{#299823}

[aurimas (slooooooooow), 2014-10-15 18:40:10]

aurimas@chromium.org changed reviewers:
+ lambroslambrou@chromium.org, newt@chromium.org, yfriedman@chromium.org

[aurimas (slooooooooow), 2014-10-15 18:40:10]

newt@chromium.org: Please review changes in 
ui/

lambroslambrou@chromium.org: Please review changes in 
remoting/

yfriedman@chromium.org: Please review changes in 
net/ sync/ testing/ tools/

[newt (away), 2014-10-15 20:10:13]

ui lgtm

[Yaron, 2014-10-15 20:19:00]

rs lgtm

[Lambros, 2014-10-15 20:55:51]

https://codereview.chromium.org/654293002/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/654293002/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:287:
R.string.footer_connecting), true, true,
Optional nit:
Google style guide says "prefer to break at a higher syntactic level":
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.5.1-line...

which would mean the break should be before 'getString'', not after it?

I guess the lint tool you're using isn't aware of this rule? Or this rule
doesn't apply to us?

https://codereview.chromium.org/654293002/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:289: @Override
Should "@Override" be indented to match up with 'public' below it?

https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.8.5-anno...

[aurimas (slooooooooow), 2014-10-15 21:18:48]

https://chromiumcodereview.appspot.com/654293002/diff/1/remoting/android/java...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://chromiumcodereview.appspot.com/654293002/diff/1/remoting/android/java...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:287:
R.string.footer_connecting), true, true,
On 2014/10/15 20:55:51, Lambros wrote:
> Optional nit:
> Google style guide says "prefer to break at a higher syntactic level":
>
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.5.1-line...
> 
> which would mean the break should be before 'getString'', not after it?
> 
> I guess the lint tool you're using isn't aware of this rule? Or this rule
> doesn't apply to us?

Sadly Checkstyle does not seem to be aware of this rule :/
Fixed.

https://chromiumcodereview.appspot.com/654293002/diff/1/remoting/android/java...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:289: @Override
On 2014/10/15 20:55:51, Lambros wrote:
> Should "@Override" be indented to match up with 'public' below it?
> 
>
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.8.5-anno...

Yep, my bad on this one.

[aurimas (slooooooooow), 2014-10-15 21:19:19]

aurimas@chromium.org changed reviewers:
+ avayvod@chromium.org

[aurimas (slooooooooow), 2014-10-15 21:19:20]

avayvod@chromium.org: Please review changes in 
printing/

[Lambros, 2014-10-15 22:10:19]

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:289: @Override
@Override still not fixed :) Also, shouldn't "new DialogInterface..." be aligned
with GetString(..) above it, as they are both parameters of the show(...)
method-call?

[whywhat, 2014-10-15 23:12:38]

printing/ lgtm!

https://codereview.chromium.org/654293002/diff/20001/net/android/java/src/org...
File net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java (right):

https://codereview.chromium.org/654293002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java:250: if
(telephonyManager != null) {
nit:

if (telephonyManager == null) return "";
return telephonyManager.getNetworkCountryIso();

would be a little more readable and slightly shorter, imho.

https://codereview.chromium.org/654293002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java:264: if
(telephonyManager != null) {
nit: ditto

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:289: @Override
On 2014/10/15 22:10:19, Lambros wrote:
> @Override still not fixed :) Also, shouldn't "new DialogInterface..." be
aligned
> with GetString(..) above it, as they are both parameters of the show(...)
> method-call?

I'd even say putting each argument of show() on its own line would be a
readability win. Although it's just me :)

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:74:
mActivityLifecycleListener.onActivityPaused(this);
nit: fits on one line I think?

[aurimas (slooooooooow), 2014-10-15 23:29:48]

Sorry for all the trouble :)

https://codereview.chromium.org/654293002/diff/20001/net/android/java/src/org...
File net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java (right):

https://codereview.chromium.org/654293002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java:250: if
(telephonyManager != null) {
On 2014/10/15 23:12:38, whywhat wrote:
> nit:
> 
> if (telephonyManager == null) return "";
> return telephonyManager.getNetworkCountryIso();
> 
> would be a little more readable and slightly shorter, imho.

Done.

https://codereview.chromium.org/654293002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java:264: if
(telephonyManager != null) {
On 2014/10/15 23:12:38, whywhat wrote:
> nit: ditto

Done.

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:289: @Override
On 2014/10/15 23:12:38, whywhat wrote:
> On 2014/10/15 22:10:19, Lambros wrote:
> > @Override still not fixed :) Also, shouldn't "new DialogInterface..." be
> aligned
> > with GetString(..) above it, as they are both parameters of the show(...)
> > method-call?
> 
> I'd even say putting each argument of show() on its own line would be a
> readability win. Although it's just me :)

Done.

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/654293002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:74:
mActivityLifecycleListener.onActivityPaused(this);
On 2014/10/15 23:12:38, whywhat wrote:
> nit: fits on one line I think?

Done.

[Lambros, 2014-10-16 00:57:34]

remoting/ lgtm, thanks for the cleanup!

[aurimas (slooooooooow), 2014-10-16 00:57:50]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-10-16 01:00:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/654293002/40001

[commit-bot: I haz the power, 2014-10-16 02:27:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-16 02:28:47]

Patchset 3 (id:??) landed as
https://crrev.com/38aa15f1d56f69c0d2d265497ffeb6e8645e79ff
Cr-Commit-Position: refs/heads/master@{#299823}