Source/platform/fonts/shaping/HarfBuzzShaper.cpp - Issue 652483002: TextRun::length() should return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 652483002: TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/shaping/HarfBuzzShaper.cpp

diff --git a/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

index bcf441c52f205f331c6ae205cf4aa08369f9f3f3..cf3a64849a1e544d4c87406e329c6edd00c4bd85 100644

--- a/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

+++ b/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

@@ -445,9 +445,8 @@ void HarfBuzzShaper::setPadding(int padding)

}

-void HarfBuzzShaper::setDrawRange(int from, int to)

+void HarfBuzzShaper::setDrawRange(unsigned from, unsigned to)

{

- ASSERT_WITH_SECURITY_IMPLICATION(from >= 0);

ASSERT_WITH_SECURITY_IMPLICATION(to <= m_run.length());

m_fromIndex = from;

m_toIndex = to;