Source/platform/fonts/Font.h - Issue 652483002: TextRun::length() should return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.h

Issue 652483002: TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/Font.h

diff --git a/Source/platform/fonts/Font.h b/Source/platform/fonts/Font.h

index 70abf997afcfb50f5baac977820f8b7ce4e3224b..38e9bf8291dfa0c5c3238ef8e09782e8ef6fc957 100644

--- a/Source/platform/fonts/Font.h

+++ b/Source/platform/fonts/Font.h

@@ -104,7 +104,7 @@ public:

void drawEmphasisMarks(GraphicsContext*, const TextRunPaintInfo&, const AtomicString& mark, const FloatPoint&) const;

float width(const TextRun&, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const;

- float width(const TextRun&, int& charsConsumed, Glyph& glyphId) const;

+ float width(const TextRun&, unsigned& charsConsumed, Glyph& glyphId) const;

int offsetForPosition(const TextRun&, float position, bool includePartialGlyphs) const;

FloatRect selectionRectForText(const TextRun&, const FloatPoint&, int h, int from = 0, int to = -1, bool accountForGlyphBounds = false) const;