Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: Source/platform/fonts/shaping/HarfBuzzShaper.h

Issue 652483002: TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 class HarfBuzzShaper final { 52 class HarfBuzzShaper final {
53 public: 53 public:
54 enum ForTextEmphasisOrNot { 54 enum ForTextEmphasisOrNot {
55 NotForTextEmphasis, 55 NotForTextEmphasis,
56 ForTextEmphasis 56 ForTextEmphasis
57 }; 57 };
58 58
59 HarfBuzzShaper(const Font*, const TextRun&, ForTextEmphasisOrNot = NotForTex tEmphasis, HashSet<const SimpleFontData*>* fallbackFonts = 0); 59 HarfBuzzShaper(const Font*, const TextRun&, ForTextEmphasisOrNot = NotForTex tEmphasis, HashSet<const SimpleFontData*>* fallbackFonts = 0);
60 60
61 void setDrawRange(int from, int to); 61 void setDrawRange(unsigned from, unsigned to);
62 bool shape(GlyphBuffer* = 0); 62 bool shape(GlyphBuffer* = 0);
63 float totalWidth() { return m_totalWidth; } 63 float totalWidth() { return m_totalWidth; }
64 int offsetForPosition(float targetX); 64 int offsetForPosition(float targetX);
65 FloatRect selectionRect(const FloatPoint&, int height, int from, int to); 65 FloatRect selectionRect(const FloatPoint&, int height, int from, int to);
66 FloatBoxExtent glyphBoundingBox() const { return m_glyphBoundingBox; } 66 FloatBoxExtent glyphBoundingBox() const { return m_glyphBoundingBox; }
67 67
68 private: 68 private:
69 class HarfBuzzRun { 69 class HarfBuzzRun {
70 public: 70 public:
71 HarfBuzzRun(const HarfBuzzRun&); 71 HarfBuzzRun(const HarfBuzzRun&);
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 float m_totalWidth; 156 float m_totalWidth;
157 FloatBoxExtent m_glyphBoundingBox; 157 FloatBoxExtent m_glyphBoundingBox;
158 HashSet<const SimpleFontData*>* m_fallbackFonts; 158 HashSet<const SimpleFontData*>* m_fallbackFonts;
159 159
160 friend struct CachedShapingResults; 160 friend struct CachedShapingResults;
161 }; 161 };
162 162
163 } // namespace blink 163 } // namespace blink
164 164
165 #endif // HarfBuzzShaper_h 165 #endif // HarfBuzzShaper_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698