chrome/common/extensions/manifest_url_handler.cc - Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mt Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/app_launch_info.cc ('k') | chrome/common/extensions/permissions/permissions_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_url_handler.cc

diff --git a/chrome/common/extensions/manifest_url_handler.cc b/chrome/common/extensions/manifest_url_handler.cc

index 538f1a9bf81d9f10a5af49f198872621caf15130..2531ffd4604ec9888f451a04abba007497a79c4d 100644

--- a/chrome/common/extensions/manifest_url_handler.cc

+++ b/chrome/common/extensions/manifest_url_handler.cc

@@ -17,6 +17,7 @@

#include "chrome/common/extensions/permissions/permissions_data.h"

#include "chrome/common/url_constants.h"

#include "extensions/common/error_utils.h"

+#include "extensions/common/extension_urls.h"

#include "extensions/common/manifest.h"

#include "extensions/common/manifest_constants.h"

#include "extensions/common/permissions/api_permission.h"

@@ -57,7 +58,7 @@ const GURL ManifestURL::GetHomepageURL(const Extension* extension) {

if (homepage_url.is_valid())

return homepage_url;

return UpdatesFromGallery(extension) ?

- GURL(extension_urls::GetWebstoreItemDetailURLPrefix() + extension->id()) :

+ GURL(GetWebstoreItemDetailURLPrefix() + extension->id()) :

GURL::EmptyGURL();

}

@@ -79,7 +80,7 @@ const GURL& ManifestURL::GetOptionsPage(const Extension* extension) {

// static

const GURL ManifestURL::GetDetailsURL(const Extension* extension) {

return extension->from_webstore() ?

- GURL(extension_urls::GetWebstoreItemDetailURLPrefix() + extension->id()) :

+ GURL(GetWebstoreItemDetailURLPrefix() + extension->id()) :

GURL::EmptyGURL();

}