chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mt Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 94834437bd53615b29a57cb431f336b70fdec395..f3966e44b06ee3d227eb5394379be2e27740a52e 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -78,6 +78,7 @@

#include "extensions/browser/lazy_background_task_queue.h"

#include "extensions/browser/view_type_utils.h"

#include "extensions/common/constants.h"

+#include "extensions/common/extension_urls.h"

#include "extensions/common/manifest_handlers/incognito_info.h"

#include "grit/browser_resources.h"

#include "grit/chromium_strings.h"

@@ -93,6 +94,15 @@ using content::WebContents;

namespace extensions {

+namespace {

+// Returns the URL to the extensions category on the Web Store.

+GURL GetExtensionGalleryURL() {

+ return GURL(GetWebstoreLaunchURL() + "/category/extensions");

+} // namespace

ExtensionPage::ExtensionPage(const GURL& url,

int render_process_id,

int render_view_id,

@@ -352,12 +362,12 @@ void ExtensionSettingsHandler::GetLocalizedValues(

source->AddString("extensionSettingsSuggestGallery",

l10n_util::GetStringFUTF16(IDS_EXTENSIONS_NONE_INSTALLED_SUGGEST_GALLERY,

ASCIIToUTF16(google_util::AppendGoogleLocaleParam(

- GURL(extension_urls::GetExtensionGalleryURL())).spec())));

+ GetExtensionGalleryURL()).spec())));

source->AddString("extensionSettingsGetMoreExtensions",

l10n_util::GetStringUTF16(IDS_GET_MORE_EXTENSIONS));

source->AddString("extensionSettingsGetMoreExtensionsUrl",

ASCIIToUTF16(google_util::AppendGoogleLocaleParam(

- GURL(extension_urls::GetExtensionGalleryURL())).spec()));

+ GetExtensionGalleryURL()).spec()));

source->AddString("extensionSettingsExtensionId",

l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID));

source->AddString("extensionSettingsExtensionPath",