chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('k') | chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc » ('j') | chrome/common/extensions/extension_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index 6968c55964a24c8562eae08b87d1d0a316d162e0..c51d57bf7dfa6c3593b6cb0adaeb0f2e0be27507 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -16,10 +16,10 @@

#include "chrome/browser/ui/views/constrained_window_views.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_constants.h"

#include "chrome/installer/util/browser_distribution.h"

#include "content/public/browser/page_navigator.h"

#include "content/public/browser/web_contents.h"

+#include "extensions/common/extension_urls.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

#include "grit/google_chrome_strings.h"

@@ -679,7 +679,7 @@ string16 ExtensionInstallDialogView::GetWindowTitle() const {

void ExtensionInstallDialogView::LinkClicked(views::Link* source,

int event_flags) {

- GURL store_url(extension_urls::GetWebstoreItemDetailURLPrefix() +

+ GURL store_url(extensions::GetWebstoreItemDetailURLPrefix() +

prompt_.extension()->id());

OpenURLParams params(

store_url, Referrer(), NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK,