DevTools: Refactor InspectUI class for extensibility

DevTools: Refactor InspectUI class for extensibility

Currently InspectUI contains code that listens to inspection targets coming from 3 different sources (RVHs, workers, ADB) which makes it quite complex and intertwined. More sources are to come soon (e.g. targets from wirelessly connected devices). This patch extracts a base class DevToolsTargetsUIHandler that should be used to add another target source.

TBR=jochen@chromium.org for chrome.gyp
BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234859

[Vladislav Kaznacheev, 2013-11-12 11:49:51]

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
File chrome/browser/resources/inspect/inspect.js (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
chrome/browser/resources/inspect/inspect.js:822: if (window.WebInspector) {
Please disregard, this crept in from another patch

[vsevik, 2013-11-12 14:24:07]

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
File chrome/browser/devtools/devtools_targets_ui.cc (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
chrome/browser/devtools/devtools_targets_ui.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
ditto

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
chrome/browser/devtools/devtools_targets_ui.cc:220: void EnumerateOnUIThread() {
Seeing a method with a name that ends with "OnUIThread" being called on IO
thread is confusing.

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
File chrome/browser/devtools/devtools_targets_ui.h (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
chrome/browser/devtools/devtools_targets_ui.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
2013

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
File chrome/browser/resources/inspect/inspect.js (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
chrome/browser/resources/inspect/inspect.js:256: sendCommand(
I would use sendTargetCommand(browser, url) instead.

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
chrome/browser/resources/inspect/inspect.js:822: if (window.WebInspector) {
Why is this needed?

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/ui/...
File chrome/browser/ui/webui/inspect_ui.h (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/ui/...
chrome/browser/ui/webui/inspect_ui.h:2: // Use of this source_id code is
governed by a BSD-style license that can be
revert

[vsevik, 2013-11-12 14:24:55]

lgtm

[Vladislav Kaznacheev, 2013-11-13 16:02:32]

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
File chrome/browser/devtools/devtools_targets_ui.cc (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
chrome/browser/devtools/devtools_targets_ui.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2013/11/12 14:24:07, vsevik wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
chrome/browser/devtools/devtools_targets_ui.cc:220: void EnumerateOnUIThread() {

On 2013/11/12 14:24:07, vsevik wrote:
> Seeing a method with a name that ends with "OnUIThread" being called on IO
> thread is confusing.

Oops. What was I thinking. Done.

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
File chrome/browser/devtools/devtools_targets_ui.h (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/dev...
chrome/browser/devtools/devtools_targets_ui.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2013/11/12 14:24:07, vsevik wrote:
> 2013

Done.

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
File chrome/browser/resources/inspect/inspect.js (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
chrome/browser/resources/inspect/inspect.js:256: sendCommand(
sendTargetCommand accepts 3 args (command, source and id). Rewriting it to
accept varargs makes it overly complicated.
On 2013/11/12 14:24:07, vsevik wrote:
> I would use sendTargetCommand(browser, url) instead.

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/res...
chrome/browser/resources/inspect/inspect.js:822: if (window.WebInspector) {
On 2013/11/12 14:24:07, vsevik wrote:
> Why is this needed?

Done.

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/ui/...
File chrome/browser/ui/webui/inspect_ui.h (right):

https://chromiumcodereview.appspot.com/65143004/diff/40001/chrome/browser/ui/...
chrome/browser/ui/webui/inspect_ui.h:2: // Use of this source_id code is
governed by a BSD-style license that can be
On 2013/11/12 14:24:07, vsevik wrote:
> revert

Done.

[commit-bot: I haz the power, 2013-11-13 16:04:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/65143004/140001

[commit-bot: I haz the power, 2013-11-13 18:42:40]

Change committed as 234859