content/browser/frame_host/interstitial_page_impl.cc - Issue 647613002: Fix RenderWidgetHostViewGuest leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bring back mac delegate() Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/interstitial_page_impl.cc

diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc

index 4628c70aa6e7880719aba5b57bdac2c7e2671dd3..6899d429612794740c81c56d3f82f45d904e7958 100644

--- a/content/browser/frame_host/interstitial_page_impl.cc

+++ b/content/browser/frame_host/interstitial_page_impl.cc

@@ -581,7 +581,7 @@ WebContentsView* InterstitialPageImpl::CreateWebContentsView() {

WebContentsView* wcv =

static_cast<WebContentsImpl*>(web_contents())->GetView();

RenderWidgetHostViewBase* view =

- wcv->CreateViewForWidget(render_view_host_);

+ wcv->CreateViewForWidget(render_view_host_, false);

render_view_host_->SetView(view);

render_view_host_->AllowBindings(BINDINGS_POLICY_DOM_AUTOMATION);