chrome/browser/apps/web_view_browsertest.cc - Issue 647613002: Fix RenderWidgetHostViewGuest leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bring back mac delegate() Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/web_view_browsertest.cc

diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc

index ed11fef02ea71cc5cf67d05d9ae9933b4f1e07ae..6ae6853fb7113ab0dd123ff31e0b8240eb5e0aad 100644

--- a/chrome/browser/apps/web_view_browsertest.cc

+++ b/chrome/browser/apps/web_view_browsertest.cc

@@ -1217,13 +1217,7 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestResizeWebviewResizesContent) {

// This test makes sure we do not crash if app is closed while interstitial

// page is being shown in guest.

-// Disabled under LeakSanitizer due to memory leaks. http://crbug.com/321662

-#if defined(LEAK_SANITIZER)

-#define MAYBE_InterstitialTeardown DISABLED_InterstitialTeardown

-#else

-#define MAYBE_InterstitialTeardown InterstitialTeardown

-#endif

-IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_InterstitialTeardown) {

+IN_PROC_BROWSER_TEST_F(WebViewTest, InterstitialTeardown) {

#if defined(OS_WIN)

// Flaky on XP bot http://crbug.com/297014

if (base::win::GetVersion() <= base::win::VERSION_XP)

« no previous file with comments | « no previous file | chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm » ('j') | no next file with comments »