Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/web_contents/web_contents_view_android.h

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add is_guest_view_hack_ to RWHV Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/renderer_host/render_widget_host_view_mac_unittest.mm ('K') | « content/browser/web_contents/web_contents_view.h ('k') | content/browser/web_contents/web_contents_view_android.cc » ('j') | content/browser/web_contents/web_contents_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_android.h
diff --git a/content/browser/web_contents/web_contents_view_android.h b/content/browser/web_contents/web_contents_view_android.h
index e4c9e60672c9e46b29f9e4370ede4007c3e6e2c9..6503aff3570840990b293713cac0fd9b1e03dbba 100644
--- a/content/browser/web_contents/web_contents_view_android.h
+++ b/content/browser/web_contents/web_contents_view_android.h
@@ -44,9 +44,9 @@ class WebContentsViewAndroid : public WebContentsView,
virtual void CreateView(
const gfx::Size& initial_size, gfx::NativeView context) override;
virtual RenderWidgetHostViewBase* CreateViewForWidget(
- RenderWidgetHost* render_widget_host) override;
+ RenderWidgetHost* render_widget_host, bool is_guest_view_hack) override;
virtual RenderWidgetHostViewBase* CreateViewForPopupWidget(
- RenderWidgetHost* render_widget_host) override;
+ RenderWidgetHost* render_widget_host, bool is_guest_view_hack) override;
virtual void SetPageTitle(const base::string16& title) override;
virtual void RenderViewCreated(RenderViewHost* host) override;
virtual void RenderViewSwappedIn(RenderViewHost* host) override;
« content/browser/renderer_host/render_widget_host_view_mac_unittest.mm ('K') | « content/browser/web_contents/web_contents_view.h ('k') | content/browser/web_contents/web_contents_view_android.cc » ('j') | content/browser/web_contents/web_contents_view_guest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698