content/browser/browser_plugin/browser_plugin_guest.cc - Issue 647613002: Fix RenderWidgetHostViewGuest leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add is_guest_view_hack_ to RWHV Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 09326d1990331df62b3986af993505e1bc4ff9bb..e50a87bdfa22a76e4e8f31a54cfe6580fa16b6db 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -547,7 +547,7 @@ void BrowserPluginGuest::Attach(

static_cast<WebContentsViewGuest*>(GetWebContents()->GetView());

if (!web_contents()->GetRenderViewHost()->GetView()) {

web_contents_view->CreateViewForWidget(

- web_contents()->GetRenderViewHost());

+ web_contents()->GetRenderViewHost(), true);

}