Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: content/browser/web_contents/web_contents_view_mac.h

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add is_guest_view_hack_ check in rwhvmac-delegate call (needs review) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_MAC_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_MAC_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_MAC_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_MAC_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 virtual void SetInitialFocus() override; 75 virtual void SetInitialFocus() override;
76 virtual void StoreFocus() override; 76 virtual void StoreFocus() override;
77 virtual void RestoreFocus() override; 77 virtual void RestoreFocus() override;
78 virtual DropData* GetDropData() const override; 78 virtual DropData* GetDropData() const override;
79 virtual gfx::Rect GetViewBounds() const override; 79 virtual gfx::Rect GetViewBounds() const override;
80 virtual void SetAllowOtherViews(bool allow) override; 80 virtual void SetAllowOtherViews(bool allow) override;
81 virtual bool GetAllowOtherViews() const override; 81 virtual bool GetAllowOtherViews() const override;
82 virtual void CreateView( 82 virtual void CreateView(
83 const gfx::Size& initial_size, gfx::NativeView context) override; 83 const gfx::Size& initial_size, gfx::NativeView context) override;
84 virtual RenderWidgetHostViewBase* CreateViewForWidget( 84 virtual RenderWidgetHostViewBase* CreateViewForWidget(
85 RenderWidgetHost* render_widget_host) override; 85 RenderWidgetHost* render_widget_host, bool is_guest_view_hack) override;
86 virtual RenderWidgetHostViewBase* CreateViewForPopupWidget( 86 virtual RenderWidgetHostViewBase* CreateViewForPopupWidget(
87 RenderWidgetHost* render_widget_host) override; 87 RenderWidgetHost* render_widget_host) override;
88 virtual void SetPageTitle(const base::string16& title) override; 88 virtual void SetPageTitle(const base::string16& title) override;
89 virtual void RenderViewCreated(RenderViewHost* host) override; 89 virtual void RenderViewCreated(RenderViewHost* host) override;
90 virtual void RenderViewSwappedIn(RenderViewHost* host) override; 90 virtual void RenderViewSwappedIn(RenderViewHost* host) override;
91 virtual void SetOverscrollControllerEnabled(bool enabled) override; 91 virtual void SetOverscrollControllerEnabled(bool enabled) override;
92 virtual bool IsEventTracking() const override; 92 virtual bool IsEventTracking() const override;
93 virtual void CloseTabAfterEventTracking() override; 93 virtual void CloseTabAfterEventTracking() override;
94 94
95 // Backend implementation of RenderViewHostDelegateView. 95 // Backend implementation of RenderViewHostDelegateView.
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 bool allow_other_views_; 138 bool allow_other_views_;
139 139
140 scoped_ptr<PopupMenuHelper> popup_menu_helper_; 140 scoped_ptr<PopupMenuHelper> popup_menu_helper_;
141 141
142 DISALLOW_COPY_AND_ASSIGN(WebContentsViewMac); 142 DISALLOW_COPY_AND_ASSIGN(WebContentsViewMac);
143 }; 143 };
144 144
145 } // namespace content 145 } // namespace content
146 146
147 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_MAC_H_ 147 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698