Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc

Issue 646853005: Disable BaselinePolicy.SIGSYS_InvalidSyscall on Chrome OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
diff --git a/sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc b/sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
index a71975bb97fc3c159226be1461d377b879120de3..76eef06457818840cae5f74d58c5184800d54914 100644
--- a/sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
+++ b/sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
@@ -213,12 +213,15 @@ BPF_TEST_C(BaselinePolicy, EPERM_getcwd, BaselinePolicy) {
BPF_ASSERT_EQ(EPERM, errno);
}
+// TODO(jorgelo): re-enable this after crbug.com/424973 is fixed.
+#if !defined(OS_CHROMEOS)
BPF_DEATH_TEST_C(BaselinePolicy,
SIGSYS_InvalidSyscall,
DEATH_SEGV_MESSAGE(GetErrorMessageContentForTests()),
BaselinePolicy) {
mdempsky 2014/10/20 17:33:47 Can you instead add a DISABLE_ON_CHROMEOS macro to
Jorge Lucangeli Obes 2014/10/20 17:43:23 Done.
Syscall::InvalidCall();
}
+#endif
// A failing test using this macro could be problematic since we perform
// system calls by passing "0" as every argument.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698