Disable BaselinePolicy.SIGSYS_InvalidSyscall on Chrome OS.

Disable BaselinePolicy.SIGSYS_InvalidSyscall on Chrome OS.

BUG=424973
TEST=chromeos=1 compile,
TEST=out_chromeos/Debug/sandbox_linux_unittests --gtest_filter=*SIGSYS_InvalidSyscall*
...
0 tests run

R=mdempsky@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/5893f9aa6d302579bed743cb6377aa24c6bfe5af

[Jorge Lucangeli Obes, 2014-10-20 17:31:35]

jorgelo@chromium.org changed reviewers:
+ leecam@chromium.org, mdempsky@chromium.org

[Jorge Lucangeli Obes, 2014-10-20 17:31:35]

Temporarily disabling test.

[mdempsky, 2014-10-20 17:33:47]

lgtm with nit

https://chromiumcodereview.appspot.com/646853005/diff/1/sandbox/linux/seccomp...
File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc (right):

https://chromiumcodereview.appspot.com/646853005/diff/1/sandbox/linux/seccomp...
sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc:221:
BaselinePolicy) {
Can you instead add a DISABLE_ON_CHROMEOS macro to
sandbox/linux/tests/unit_tests.h and use that here?

[Jorge Lucangeli Obes, 2014-10-20 17:43:23]

PTAL, thought I'm getting compile errors that I cannot explain.

https://chromiumcodereview.appspot.com/646853005/diff/1/sandbox/linux/seccomp...
File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc (right):

https://chromiumcodereview.appspot.com/646853005/diff/1/sandbox/linux/seccomp...
sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc:221:
BaselinePolicy) {
On 2014/10/20 17:33:47, mdempsky wrote:
> Can you instead add a DISABLE_ON_CHROMEOS macro to
> sandbox/linux/tests/unit_tests.h and use that here?

Done.

[mdempsky, 2014-10-20 17:46:02]

On 2014/10/20 17:43:23, Jorge Lucangeli Obes wrote:
> PTAL, thought I'm getting compile errors that I cannot explain.

Blah, the C preprocessor is a cruel mistress.  LGTM on patch set 1.

[commit-bot: I haz the power, 2014-10-20 18:01:00]

Patchset 4 (id:??) landed as
https://crrev.com/5893f9aa6d302579bed743cb6377aa24c6bfe5af
Cr-Commit-Position: refs/heads/master@{#300299}

[Jorge Lucangeli Obes, 2014-10-20 18:01:03]

Committed patchset #4 (id:2) manually as
5893f9aa6d302579bed743cb6377aa24c6bfe5af (presubmit successful).