Update Checkstyle to version 5.8

Update Checkstyle to version 5.8

Changes in 5.8 are described here:
http://checkstyle.sourceforge.net/releasenotes.html

BUG=318404
R=yfriedman@chromium.org

Committed: https://crrev.com/0ecd518d01e94f37db215245013349e5975d9042
Cr-Commit-Position: refs/heads/master@{#299207}

[aurimas (slooooooooow), 2014-10-10 21:43:57]

aurimas@chromium.org changed reviewers:
+ yfriedman@chromium.org

[aurimas (slooooooooow), 2014-10-10 21:43:58]

Hey Yaron,

Please take a look at this change.

Thanks,
Aurimas

[Yaron, 2014-10-10 22:27:40]

What's new?

On Fri Oct 10 2014 at 2:43:58 PM <aurimas@chromium.org> wrote:

> Reviewers: Yaron,
>
> Message:
> Hey Yaron,
>
> Please take a look at this change.
>
> Thanks,
> Aurimas
>
> Description:
> Update Checkstyle to version 5.8
>
> Changes in 5.8 are described here:
> http://checkstyle.sourceforge.net/releasenotes.html
>
> BUG=318404
>
> Please review this at https://chromiumcodereview.appspot.com/644133002/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+2, -2 lines):
>    M third_party/checkstyle/README.chromium
>    D third_party/checkstyle/checkstyle-5.7-all.jar
>    A + third_party/checkstyle/checkstyle-5.8-all.jar
>    M tools/android/checkstyle/checkstyle.py
>
>
> Index: third_party/checkstyle/checkstyle-5.7-all.jar
> diff --git a/third_party/checkstyle/checkstyle-5.7-all.jar
> b/third_party/checkstyle/checkstyle-5.7-all.jar
> deleted file mode 100644
> index
> 1bc6dbd9d3f9a0308fa4884d748c6374e9d23fa2..000000000000000000000000000000
> 0000000000
> Binary files a/third_party/checkstyle/checkstyle-5.7-all.jar and /dev/null
> differ
> Index: third_party/checkstyle/README.chromium
> diff --git a/third_party/checkstyle/README.chromium
> b/third_party/checkstyle/README.chromium
> index
> fcc21de98a3741b15cc06d1b7651265b6bc1ca11..89bc1d1f9a4439bc32661ca8f87980
> 604624175a
> 100644
> --- a/third_party/checkstyle/README.chromium
> +++ b/third_party/checkstyle/README.chromium
> @@ -2,7 +2,7 @@ Name: Checkstyle is a development tool to help programmers
> write Java code that
>         adheres to a coding standard.
>   Short Name: checkstyle
>   URL: http://checkstyle.sourceforge.net/
> -Version <http://checkstyle.sourceforge.net/-Version>: 5.7
> +Version: 5.8
>   License: LGPL 2.1
>   License File: LICENSE
>   Security Critical: no
> @@ -17,9 +17,9 @@ Local Modifications:
>     - checkstyle_checks.xml
>     - import-control.xml
>     - supressions.xml
> -- Removed jars already included in checkstyle-5.7-all.jar
> +- Removed jars already included in checkstyle-5.8-all.jar
>     - antlr-2.7.7.jar
> -  - checkstyle-5.7.jar
> +  - checkstyle-5.8.jar
>     - commons-beanutils-core-1.8.3.jar
>     - commons-cli-1.2.jar
>     - commons-logging-1.1.1.jar
> Index: third_party/checkstyle/checkstyle-5.8-all.jar
> diff --git a/third_party/checkstyle/checkstyle-5.7-all.jar
> b/third_party/checkstyle/checkstyle-5.8-all.jar
> similarity index 78%
> rename from third_party/checkstyle/checkstyle-5.7-all.jar
> rename to third_party/checkstyle/checkstyle-5.8-all.jar
> index
> 1bc6dbd9d3f9a0308fa4884d748c6374e9d23fa2..abecb4c2d6e45d7999743e2f8157ad
> da4fca880a
> 100644
> Binary files a/third_party/checkstyle/checkstyle-5.7-all.jar and
> b/third_party/checkstyle/checkstyle-5.8-all.jar differ
> Index: tools/android/checkstyle/checkstyle.py
> diff --git a/tools/android/checkstyle/checkstyle.py
> b/tools/android/checkstyle/checkstyle.py
> index
> 25f202fdc56a54c3046071e753e26793ece40d68..df9014dc650aae93879f963c42089f
> 5492abeef4
> 100644
> --- a/tools/android/checkstyle/checkstyle.py
> +++ b/tools/android/checkstyle/checkstyle.py
> @@ -12,7 +12,7 @@ CHROMIUM_SRC = os.path.normpath(
>       os.path.join(os.path.dirname(__file__),
>                    os.pardir, os.pardir, os.pardir))
>   CHECKSTYLE_ROOT = os.path.join(CHROMIUM_SRC, 'third_party', 'checkstyle',
> -                               'checkstyle-5.7-all.jar')
> +                               'checkstyle-5.8-all.jar')
>
>
>   def RunCheckstyle(input_api, output_api, style_file):
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[aurimas (slooooooooow), 2014-10-10 22:35:29]

Changelog link is in the CL description, but in short: bugfixes and partial
support for Google Java style config[1]

[1] https://github.com/checkstyle/checkstyle/blob/master/google_checks.xml

[Yaron, 2014-10-10 22:38:26]

lgtm

[aurimas (slooooooooow), 2014-10-10 22:55:23]

Committed patchset #1 (id:1) manually as
0ecd518d01e94f37db215245013349e5975d9042 (presubmit successful).

[commit-bot: I haz the power, 2014-10-10 22:55:24]

Patchset 1 (id:??) landed as
https://crrev.com/0ecd518d01e94f37db215245013349e5975d9042
Cr-Commit-Position: refs/heads/master@{#299207}