Adding app_view tests to app_shell_browsertests.

extensions/test/data/app_view/apitest/main.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var util = {};
 var embedder = {};
-embedder.baseGuestURL = '';
-embedder.emptyGuestURL = '';
-embedder.windowOpenGuestURL = '';
-embedder.noReferrerGuestURL = '';
-embedder.redirectGuestURL = '';
-embedder.redirectGuestURLDest = '';
-embedder.closeSocketURL = '';
-embedder.tests = {};
-
-embedder.setUp_ = function(config) {
-  if (!config || !config.testServer) {
-    return;
-  }
-  embedder.baseGuestURL = 'http://localhost:' + config.testServer.port;
-  embedder.emptyGuestURL = embedder.baseGuestURL +
-      '/extensions/platform_apps/web_view/shim/empty_guest.html';
-};
 
 window.runTest = function(testName, appToEmbed) {
   if (!embedder.test.testList[testName]) {
     window.console.log('Incorrect testName: ' + testName);
     embedder.test.fail();
     return;
   }
 
   // Run the test.
   embedder.test.testList[testName](appToEmbed);
@@ skipping 27 matching lines @@
 };
 
 embedder.test.assertFalse = function(condition) {
   if (condition) {
     console.log('assertion failed: false != ' + condition);
     embedder.test.fail();
   }
 };
 
 // Tests begin.
-function testAppViewWithUndefinedDataShouldSucceed(appToEmbed) {
+function testAppViewGoodDataShouldSucceed(appToEmbed) {
   var appview = new AppView();
   LOG('appToEmbed  ' + appToEmbed);
   document.body.appendChild(appview);
-  // Step 1: Attempt to connect to a non-existant app.
-  LOG('attempting to connect to non-existant app.');
-  appview.connect('abc123', undefined, function(success) {
-    // Make sure we fail.
-    if (success) {
-      LOG('UNEXPECTED CONNECTION.');
+  LOG('Attempting to connect to app with good params.');
+  // Step 2: Attempt to connect to an app with good params.
+  appview.connect(appToEmbed, { 'foo': 'bleep' }, function(success) {

[lazyboy, 2014/10/24 20:13:25]

Here and below: no space after { or before }

[lfg, 2014/10/24 20:24:30]

Done.

+    // Make sure we don't fail.
+    if (!success) {
+      LOG('FAILED TO CONNECT.');
       embedder.test.fail();
       return;
     }
-    LOG('failed to connect to non-existant app.');
-    LOG('attempting to connect to known app.');
-    // Step 2: Attempt to connect to an app we know exists.
-    appview.connect(appToEmbed, undefined, function(success) {
-      // Make sure we don't fail.
-      if (!success) {
-        LOG('FAILED TO CONNECT.');
-        embedder.test.fail();
-        return;
-      }
-      LOG('CONNECTED.');
-      embedder.test.succeed();
-    });
+    LOG('CONNECTED.');
+    embedder.test.succeed();
   });
 };
 
 function testAppViewRefusedDataShouldFail(appToEmbed) {
   var appview = new AppView();
   LOG('appToEmbed  ' + appToEmbed);
   document.body.appendChild(appview);
   LOG('Attempting to connect to app with refused params.');
   appview.connect(appToEmbed, { 'foo': 'bar' }, function(success) {
     // Make sure we fail.
     if (success) {
       LOG('UNEXPECTED CONNECTION.');
       embedder.test.fail();
       return;
     }
     LOG('FAILED TO CONNECT.');
     embedder.test.succeed();
   });
 };
 
-function testAppViewGoodDataShouldSucceed(appToEmbed) {
+function testAppViewWithUndefinedDataShouldSucceed(appToEmbed) {
   var appview = new AppView();
   LOG('appToEmbed  ' + appToEmbed);
   document.body.appendChild(appview);
-  LOG('Attempting to connect to app with good params.');
-  // Step 2: Attempt to connect to an app with good params.
-  appview.connect(appToEmbed, { 'foo': 'bleep' }, function(success) {
-    // Make sure we don't fail.
-    if (!success) {
-      LOG('FAILED TO CONNECT.');
+  // Step 1: Attempt to connect to a non-existant app.

[lazyboy, 2014/10/24 20:13:25]

s/non-existant/non-existent
Also add note that "abc123" is the non-existent app.

[lfg, 2014/10/24 20:24:29]

Done.

+  LOG('attempting to connect to non-existant app.');

[lazyboy, 2014/10/24 20:13:25]

nit: s/attempting/Attempting

[lfg, 2014/10/24 20:24:30]

Done.

+  appview.connect('abc123', undefined, function(success) {
+    // Make sure we fail.
+    if (success) {
+      LOG('UNEXPECTED CONNECTION.');
       embedder.test.fail();
       return;
     }
-    LOG('CONNECTED.');
-    embedder.test.succeed();
+    LOG('failed to connect to non-existant app.');
+    LOG('attempting to connect to known app.');
+    // Step 2: Attempt to connect to an app we know exists.
+    appview.connect(appToEmbed, undefined, function(success) {
+      // Make sure we don't fail.
+      if (!success) {
+        LOG('FAILED TO CONNECT.');
+        embedder.test.fail();
+        return;
+      }
+      LOG('CONNECTED.');

[lazyboy, 2014/10/24 20:13:25]

nit: s/CONNECTED/Connected, SHOUT only when things are wrong =P

[lfg, 2014/10/24 20:24:30]

Done.

+      embedder.test.succeed();
+    });
   });
 };
 
 embedder.test.testList = {
+  'testAppViewGoodDataShouldSucceed': testAppViewGoodDataShouldSucceed,
+  'testAppViewRefusedDataShouldFail': testAppViewRefusedDataShouldFail,
   'testAppViewWithUndefinedDataShouldSucceed':
-      testAppViewWithUndefinedDataShouldSucceed,
-  'testAppViewRefusedDataShouldFail': testAppViewRefusedDataShouldFail,
-  'testAppViewGoodDataShouldSucceed': testAppViewGoodDataShouldSucceed
+      testAppViewWithUndefinedDataShouldSucceed
 };
 
 onload = function() {
-  chrome.test.getConfig(function(config) {
-    embedder.setUp_(config);
-    chrome.test.sendMessage('Launched');
-  });
+  chrome.test.sendMessage('LAUNCHED');
 };