Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 64193003: Clean up PrefServiceBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix indentation Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
index 901776ef0b68bfa676a7b530e687751a83b11132..4e88106504484b53169fe59c6b7b79f9a1ba0cc8 100644
--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
@@ -135,17 +135,20 @@ TEST_F(PrefProviderTest, Incognito) {
new OverlayUserPrefStore(user_prefs);
PrefServiceMockBuilder builder;
- builder.WithUserPrefs(user_prefs);
+ builder.set_user_prefs(make_scoped_refptr(user_prefs));
scoped_refptr<user_prefs::PrefRegistrySyncable> registry(
new user_prefs::PrefRegistrySyncable);
- PrefServiceSyncable* regular_prefs = builder.CreateSyncable(registry.get());
+ PrefServiceSyncable* regular_prefs =
+ builder.CreateSyncable(registry.get()).release();
chrome::RegisterUserProfilePrefs(registry.get());
- builder.WithUserPrefs(otr_user_prefs);
+ PrefServiceMockBuilder otr_builder;
+ otr_builder.set_user_prefs(make_scoped_refptr(otr_user_prefs));
scoped_refptr<user_prefs::PrefRegistrySyncable> otr_registry(
new user_prefs::PrefRegistrySyncable);
- PrefServiceSyncable* otr_prefs = builder.CreateSyncable(otr_registry.get());
+ PrefServiceSyncable* otr_prefs =
+ otr_builder.CreateSyncable(otr_registry.get()).release();
chrome::RegisterUserProfilePrefs(otr_registry.get());

Powered by Google App Engine
This is Rietveld 408576698