LayoutTests/fast/dom/element-attribute-js-null.html - Issue 64173002: Align HTMLAppletElement IDL with spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/element-attribute-js-null.html

Issue 64173002: Align HTMLAppletElement IDL with spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLAppletElement/hspace-vspace-expected.txt ('k') | LayoutTests/fast/dom/element-attribute-js-null-expected.txt » ('j') | Source/core/html/HTMLAppletElement.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/element-attribute-js-null.html

diff --git a/LayoutTests/fast/dom/element-attribute-js-null.html b/LayoutTests/fast/dom/element-attribute-js-null.html

index a1bb97b9198d41b9800c157eec82c08147c82556..092082a1fc4007b48fccb87b53113143ff9be842 100644

--- a/LayoutTests/fast/dom/element-attribute-js-null.html

+++ b/LayoutTests/fast/dom/element-attribute-js-null.html

@@ -50,7 +50,7 @@

result = "TEST FAILED: An exception should have been thrown.";

else if (isUrl && element[attr] === resolve(expected))

result = "TEST SUCCEEDED: The value was " + resultStringifier(expected) + " resolved as a URL.";

- else if (element[attr] === expected)

+ else if (!isUrl && element[attr] === expected)

result = "TEST SUCCEEDED: The value was " + resultStringifier(expected) + ".";

else

result = "TEST FAILED: The value should have been " + resultStringifier(expected) + " but was " + resultStringifier(element[attr]) + ".";

@@ -124,17 +124,15 @@

type: 'HTMLAppletElement',

elementToUse: document.createElement('applet'),

attributes: [

- {name: 'align', expectedNull: ''},

- {name: 'alt', expectedNull: ''},

- {name: 'archive', expectedNull: ''},

- {name: 'code', expectedNull: ''},

- {name: 'codeBase', expectedNull: ''},

- {name: 'height', expectedNull: ''},

- {name: 'hspace', expectedNull: ''},

- {name: 'name', expectedNull: ''},

- {name: 'object', expectedNull: ''},

- {name: 'vspace', expectedNull: ''},

- {name: 'width', expectedNull: ''}

+ {name: 'align', expectedNull: 'null'},

+ {name: 'alt', expectedNull: 'null'},

+ {name: 'archive', expectedNull: 'null'},

+ {name: 'code', expectedNull: 'null'},

+ {name: 'codeBase', expectedNull: 'null', isUrl:true},

+ {name: 'height', expectedNull: 'null'},

+ {name: 'name', expectedNull: 'null'},

+ {name: 'object', expectedNull: 'null', isUrl:true},

+ {name: 'width', expectedNull: 'null'}

]

{