Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 641203003: Read HID report descriptor from sysfs and request permission on connect. (Closed)

Created:
6 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Read HID report descriptor from sysfs and request permission on connect. The HID report descriptor can be read from sysfs instead of executing an ioctl on the device node. This means that on Chrome OS it isn't necessary to ask the permission broker for access to the device on enumeration. It can be delayed until the device is opened, as it is for USB devices. This also resolves a long-standing issue with HID devices not being enumerated on Chrome OS the first time an enumeration is requested because of the extra asynchronous step required only on that platform. BUG=411899 Committed: https://crrev.com/7832a4ee148a97057188ecb7165f9252185644f0 Cr-Commit-Position: refs/heads/master@{#299228}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -86 lines) Patch
M device/hid/hid_service.h View 1 chunk +7 lines, -0 lines 0 comments Download
M device/hid/hid_service_linux.h View 2 chunks +8 lines, -2 lines 0 comments Download
M device/hid/hid_service_linux.cc View 1 7 chunks +81 lines, -80 lines 0 comments Download
M extensions/browser/api/hid/hid_api.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 1 1 chunk +21 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
6 years, 2 months ago (2014-10-10 16:57:12 UTC) #2
Yoyo Zhou
LGTM, I'm not really familiar with the Linux internals though. https://chromiumcodereview.appspot.com/641203003/diff/1/device/hid/hid_service_linux.cc File device/hid/hid_service_linux.cc (right): https://chromiumcodereview.appspot.com/641203003/diff/1/device/hid/hid_service_linux.cc#newcode8 ...
6 years, 2 months ago (2014-10-10 23:05:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641203003/200001
6 years, 2 months ago (2014-10-11 01:13:48 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:200001)
6 years, 2 months ago (2014-10-11 01:53:06 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 01:53:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7832a4ee148a97057188ecb7165f9252185644f0
Cr-Commit-Position: refs/heads/master@{#299228}

Powered by Google App Engine
This is Rietveld 408576698