Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 633083002: Changes PlzNavitate histograms to try and simplify their multi-modal characteristic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR comments: mostly minor improvements and naming changes. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index 53db06dc3bdfe0f0520a3257623d0569515ce9ce..82821b5d832331019407f12b0bae6c657cde360b 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -259,6 +259,13 @@ class CONTENT_EXPORT RenderProcessHostImpl
// Activates Mojo for this process. Does nothing if Mojo is already activated.
void EnsureMojoActivated();
+ // PlzNavigate
+ // Getter for the time the first call to Init completed successfully (after a
clamy 2014/10/14 07:09:25 nit: s/Getter for/Returns
carlosk 2014/10/14 09:03:27 Done.
+ // new renderer process was created); further calls to Init won't change this
+ // value.
+ // NOTE: Will disappear after PlzNavitate is completed.
clamy 2014/10/14 07:09:25 nit: s/NOTE/Note
carlosk 2014/10/14 09:03:27 Done.
+ const base::TimeTicks& init_time() const { return init_time_; }
+
protected:
// A proxy for our IPC::Channel that lives on the IO thread (see
// browser_process.h)
@@ -371,6 +378,10 @@ class CONTENT_EXPORT RenderProcessHostImpl
// also reset that in the case of process termination.
bool is_initialized_;
+ // PlzNavigate
+ // Stores the time at which the first call to Init happened.
+ base::TimeTicks init_time_;
+
// Used to launch and terminate the process without blocking the UI thread.
scoped_ptr<ChildProcessLauncher> child_process_launcher_;

Powered by Google App Engine
This is Rietveld 408576698