chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm - Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: split Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/autofill/autofill_section_container.mm ('K') | « chrome/browser/ui/cocoa/autofill/autofill_section_container.mm ('k') | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

index 4a7d46b493466afef5fce084a8d95c17ac1dd4e1..35864f33b6b6efd3248938b24f27db909fd1b471 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

@@ -16,6 +16,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "testing/gtest_mac.h"

#include "testing/platform_test.h"

+#include "ui/base/l10n/l10n_util.h"

#include "ui/base/models/combobox_model.h"

#include "ui/base/models/simple_menu_model.h"

#import "ui/base/test/ui_cocoa_test_helper.h"

@@ -121,7 +122,7 @@ TEST_F(AutofillSectionContainerTest, OutputMatchesDefinition) {

const DetailInput kTestInputs[] = {

{ DetailInput::LONG,

EMAIL_ADDRESS,

- IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },

+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },

{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH },

};

autofill::MonthComboboxModel comboModel;

@@ -186,7 +187,7 @@ TEST_F(AutofillSectionContainerTest, FieldsAreInitiallyValid) {

const DetailInput kTestInputs[] = {

{ DetailInput::LONG,

EMAIL_ADDRESS,

- IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },

+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },

{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH },

};

@@ -214,7 +215,9 @@ TEST_F(AutofillSectionContainerTest, ControllerInformsValidity) {

using namespace testing;

const DetailInput kTestInputs[] = {

- { DetailInput::LONG, EMAIL_ADDRESS, IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },

+ { DetailInput::LONG,

+ EMAIL_ADDRESS,

+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },

{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH }

};