Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2870)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_types.h

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: split Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_types.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_types.h b/chrome/browser/ui/autofill/autofill_dialog_types.h
index be794a0818866b45da2cbe267c104f98c8be4238..bcb80a770ecff1745e5622dc757ca42d7f802262 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_types.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_types.h
@@ -32,9 +32,10 @@ class AutofillField;
// dialog.
struct DetailInput {
enum Length {
- SHORT, // Short inputs share a line with other short inputs. [ CVC ][ Zip ]
- LONG, // Long inputs will be given their own full line. [ City ]
- NONE, // Input will not be shown.
+ SHORT, // Shares a line with other short inputs. -> [ CVC ][ Zip ]
+ SHORT_EOL, // Shares a line but causes inputs to wrap. [ CVC ][ Zip ] <-
Evan Stade 2014/01/04 00:18:04 the ascii art here isn't helping imo, especially b
Dan Beam 2014/01/04 00:50:47 Done.
+ LONG, // Will be given its own full line. -> [ City ] <-
+ NONE, // Input will not be shown.
};
// Used to determine which inputs share lines when laying out.
@@ -42,8 +43,8 @@ struct DetailInput {
ServerFieldType type;
- // Placeholder text resource ID.
- int placeholder_text_rid;
+ // Text shown when the input is at its default state (e.g. empty).
+ base::string16 placeholder_text;
// A number between 0 and 1.0 that describes how much of the horizontal space
// in the row should be allotted to this input. 0 is equivalent to 1.

Powered by Google App Engine
This is Rietveld 408576698