Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/search/suggestions/suggestions_service_factory.cc

Issue 630073002: [Suggestions] Create ImageEncoder, to abstract away image encode/decode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/suggestions/suggestions_service_factory.cc
diff --git a/chrome/browser/search/suggestions/suggestions_service_factory.cc b/chrome/browser/search/suggestions/suggestions_service_factory.cc
index 4a98018a237455c7f7f9303262aefff74013e4cd..f8b714bbd74d477fbe949aab3726f0da1e00d20d 100644
--- a/chrome/browser/search/suggestions/suggestions_service_factory.cc
+++ b/chrome/browser/search/suggestions/suggestions_service_factory.cc
@@ -14,8 +14,10 @@
#include "components/leveldb_proto/proto_database_impl.h"
#include "components/pref_registry/pref_registry_syncable.h"
#include "components/suggestions/blacklist_store.h"
+#include "components/suggestions/image_encoder.h"
#include "components/suggestions/image_fetcher.h"
#include "components/suggestions/image_manager.h"
+#include "components/suggestions/jpeg/jpeg_image_encoder.h"
#include "components/suggestions/proto/suggestions.pb.h"
#include "components/suggestions/suggestions_service.h"
#include "components/suggestions/suggestions_store.h"
@@ -72,11 +74,13 @@ KeyedService* SuggestionsServiceFactory::BuildServiceInstanceFor(
base::FilePath database_dir(
the_profile->GetPath().Append(FILE_PATH_LITERAL("Thumbnails")));
+ scoped_ptr<JpegImageEncoder> image_encoder(new JpegImageEncoder());
scoped_ptr<ImageFetcherImpl> image_fetcher(
new ImageFetcherImpl(the_profile->GetRequestContext()));
scoped_ptr<ImageManager> thumbnail_manager(new ImageManager(
- image_fetcher.PassAs<ImageFetcher>(),
- db.PassAs<leveldb_proto::ProtoDatabase<ImageData> >(), database_dir));
+ image_fetcher.Pass(),
+ image_encoder.Pass(),
+ db.Pass(), database_dir));
return new SuggestionsService(
the_profile->GetRequestContext(), suggestions_store.Pass(),
thumbnail_manager.Pass(), blacklist_store.Pass());

Powered by Google App Engine
This is Rietveld 408576698