Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/ic-inl.h

Issue 62953007: Handle all object types (minus smi) in load/store ICs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed commentsx Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 Assembler::set_target_address_at(address, target->instruction_start()); 93 Assembler::set_target_address_at(address, target->instruction_start());
94 if (heap->gc_state() == Heap::MARK_COMPACT) { 94 if (heap->gc_state() == Heap::MARK_COMPACT) {
95 heap->mark_compact_collector()->RecordCodeTargetPatch(address, target); 95 heap->mark_compact_collector()->RecordCodeTargetPatch(address, target);
96 } else { 96 } else {
97 heap->incremental_marking()->RecordCodeTargetPatch(address, target); 97 heap->incremental_marking()->RecordCodeTargetPatch(address, target);
98 } 98 }
99 PostPatching(address, target, old_target); 99 PostPatching(address, target, old_target);
100 } 100 }
101 101
102 102
103 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object, 103 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object) {
104 JSObject* holder) {
105 if (object->IsJSObject()) return OWN_MAP; 104 if (object->IsJSObject()) return OWN_MAP;
106 105
107 // If the object is a value, we use the prototype map for the cache. 106 // If the object is a value, we use the prototype map for the cache.
108 ASSERT(object->IsString() || object->IsSymbol() || 107 ASSERT(object->IsString() || object->IsSymbol() ||
109 object->IsNumber() || object->IsBoolean()); 108 object->IsNumber() || object->IsBoolean());
110 return PROTOTYPE_MAP; 109 return PROTOTYPE_MAP;
111 } 110 }
112 111
113 112
114 JSObject* IC::GetCodeCacheHolder(Isolate* isolate, 113 HeapObject* IC::GetCodeCacheHolder(Isolate* isolate,
115 Object* object, 114 Object* object,
116 InlineCacheHolderFlag holder) { 115 InlineCacheHolderFlag holder) {
117 Object* map_owner = 116 Object* map_owner =
118 holder == OWN_MAP ? object : object->GetPrototype(isolate); 117 holder == OWN_MAP ? object : object->GetPrototype(isolate);
119 ASSERT(map_owner->IsJSObject()); 118 return HeapObject::cast(map_owner);
120 return JSObject::cast(map_owner);
121 } 119 }
122 120
123 121
124 } } // namespace v8::internal 122 } } // namespace v8::internal
125 123
126 #endif // V8_IC_INL_H_ 124 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698