Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 62953007: Handle all object types (minus smi) in load/store ICs (Closed)

Created:
7 years, 1 month ago by Toon Verwaest
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Handle all object types (minus smi) in load/store ICs R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17755

Patch Set 1 : #

Patch Set 2 : Properly handle classic mode in load callbacks of values #

Patch Set 3 : Check the correct map in the monomorphic IC #

Patch Set 4 : Added x64 port #

Patch Set 5 : Port to ARM #

Total comments: 2

Patch Set 6 : Addressed commentsx #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -364 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 3 4 12 chunks +39 lines, -43 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 12 chunks +36 lines, -41 lines 0 comments Download
M src/ic.h View 5 chunks +18 lines, -13 lines 0 comments Download
M src/ic.cc View 1 2 3 4 5 11 chunks +72 lines, -52 lines 0 comments Download
M src/ic-inl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/stub-cache.h View 1 2 3 4 5 11 chunks +40 lines, -51 lines 0 comments Download
M src/stub-cache.cc View 1 2 3 4 5 27 chunks +102 lines, -98 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 12 chunks +36 lines, -41 lines 0 comments Download
A + test/mjsunit/load-callback-from-value-classic.js View 1 2 3 4 5 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL. This CL adds support to load properties from any object type (minus smi at ...
7 years, 1 month ago (2013-11-07 17:54:12 UTC) #1
ulan
LGTM https://codereview.chromium.org/62953007/diff/240001/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/62953007/diff/240001/src/ic.cc#newcode1202 src/ic.cc:1202: InlineCacheHolderFlag cache_holder = GetCodeCacheForObject(*object); We already have cache_holder. ...
7 years, 1 month ago (2013-11-14 14:22:45 UTC) #2
Toon Verwaest
7 years, 1 month ago (2013-11-14 16:25:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as r17755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698