Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 62803003: Run GN as part of runhooks. (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Run GN as part of runhooks. This runs GN in GYP mode before actually running GYP. Currently, GN does not produce any files used by the build, these will be added in a second step. BUG= R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236542

Patch Set 1 #

Total comments: 3

Patch Set 2 : review comments #

Total comments: 1

Patch Set 3 : git try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M build/gyp_chromium View 1 2 4 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
7 years, 1 month ago (2013-11-14 23:21:06 UTC) #1
M-A Ruel
https://codereview.chromium.org/62803003/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/62803003/diff/1/build/gyp_chromium#newcode81 build/gyp_chromium:81: 2 lines between file level symbols https://codereview.chromium.org/62803003/diff/1/build/gyp_chromium#newcode87 build/gyp_chromium:87: source_root ...
7 years, 1 month ago (2013-11-14 23:23:36 UTC) #2
brettw
PTAL, new snap up.
7 years, 1 month ago (2013-11-14 23:35:11 UTC) #3
M-A Ruel
lgtm https://codereview.chromium.org/62803003/diff/160001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/62803003/diff/160001/build/gyp_chromium#newcode112 build/gyp_chromium:112: args = sys.argv[1:] Going all the code after ...
7 years, 1 month ago (2013-11-14 23:40:09 UTC) #4
brettw
7 years ago (2013-11-21 17:36:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r236542 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698