Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: extensions/test/data/web_view/media_access/allow/embedder.js

Issue 626093002: Cleanup webview app_shell_browsertests and add webview media permission tests in app_shell_browsert… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tests_load
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/test/data/web_view/media_access/allow/embedder.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/media_access/allow/embedder.js b/extensions/test/data/web_view/media_access/allow/embedder.js
similarity index 93%
copy from chrome/test/data/extensions/platform_apps/web_view/media_access/allow/embedder.js
copy to extensions/test/data/web_view/media_access/allow/embedder.js
index 0634bcf9b6295a21e4431aef73e44ef9110e1bb4..fa7cbc168668b0564eb3a81cea405c29406cfeda 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/media_access/allow/embedder.js
+++ b/extensions/test/data/web_view/media_access/allow/embedder.js
@@ -4,20 +4,20 @@
var embedder = {};
embedder.tests = {};
+// These variables will be filled in chrome.test.getConfig() below.
embedder.baseGuestURL = '';
embedder.guestURL = '';
// Sends a message to WebViewTest denoting it is done and test
// has failed.
embedder.failTest = function(msg) {
- window.console.log('test failure, reason: ' + msg);
+ window.console.warn('test failure, reason: ' + msg);
chrome.test.sendMessage('TEST_FAILED');
};
// Sends a message to WebViewTest denoting it is done and test
// has succeeded.
embedder.maybePassTest = function() {
- window.console.log('test passed');
chrome.test.sendMessage('TEST_PASSED');
};
@@ -137,6 +137,29 @@ embedder.tests.testAllowAndThenDeny = function() {
embedder.setUpLoadStop_(webview, 'test1');
};
+embedder.tests.testAllowAsync = function() {
+ var webview = embedder.setUpGuest_();
+ if (!webview) {
+ return;
+ }
+
+ var onPermissionRequest = function(e) {
+ if (!embedder.assertCorrectMediaEvent_(e)) {
+ return;
+ }
+
+ e.preventDefault();
+ // Decide asynchronously.
+ window.setTimeout(function() {
+ e.request.allow();
+ embedder.maybePassTest();
+ }, 0);
+ };
+ webview.addEventListener('permissionrequest', onPermissionRequest);
+
+ embedder.setUpLoadStop_(webview, 'test1');
+};
+
embedder.tests.testAllowTwice = function() {
var webview = embedder.setUpGuest_();
if (!webview) {
@@ -180,43 +203,18 @@ embedder.tests.testAllowTwice = function() {
embedder.setUpLoadStop_(webview, 'test1');
};
-embedder.tests.testAllowAsync = function() {
- var webview = embedder.setUpGuest_();
- if (!webview) {
- return;
- }
-
- var onPermissionRequest = function(e) {
- if (!embedder.assertCorrectMediaEvent_(e)) {
- return;
- }
-
- e.preventDefault();
- // Decide asynchronously.
- window.setTimeout(function() {
- e.request.allow();
- embedder.maybePassTest();
- }, 0);
- };
- webview.addEventListener('permissionrequest', onPermissionRequest);
-
- embedder.setUpLoadStop_(webview, 'test1');
-};
-
embedder.tests.list = {
'testAllow': embedder.tests.testAllow,
'testAllowAndThenDeny': embedder.tests.testAllowAndThenDeny,
- 'testAllowTwice': embedder.tests.testAllowTwice,
- 'testAllowAsync': embedder.tests.testAllowAsync
+ 'testAllowAsync': embedder.tests.testAllowAsync,
+ 'testAllowTwice': embedder.tests.testAllowTwice
};
// Entry point for test, called by WebViewTest.
-function startAllowTest(testName) {
+function runTest(testName) {
chrome.test.getConfig(function(config) {
embedder.baseGuestURL = 'http://localhost:' + config.testServer.port;
- embedder.guestURL = embedder.baseGuestURL +
- '/extensions/platform_apps/web_view/media_access' +
- '/media_access_guest.html';
+ embedder.guestURL = embedder.baseGuestURL + '/media_access_guest.html';
chrome.test.log('Guest url is: ' + embedder.guestURL);
var testFunction = embedder.tests.list[testName];
@@ -229,5 +227,5 @@ function startAllowTest(testName) {
}
onload = function() {
- chrome.test.sendMessage('Launched');
+ chrome.test.sendMessage('LAUNCHED');
};

Powered by Google App Engine
This is Rietveld 408576698