Split up streams logic to prepare for PlzNavigate RDH changes.

content/browser/loader/stream_writer.h

Index: content/browser/loader/stream_writer.h
diff --git a/content/browser/loader/stream_writer.h b/content/browser/loader/stream_writer.h
new file mode 100644
index 0000000000000000000000000000000000000000..b9f3e62848acfd7b16c41d2507c9746b077269ac
--- /dev/null
+++ b/content/browser/loader/stream_writer.h
@@ -0,0 +1,83 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_LOADER_STREAM_WRITER_H_
+#define CONTENT_BROWSER_LOADER_STREAM_WRITER_H_
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "content/browser/streams/stream_write_observer.h"
+
+class GURL;
+
+namespace net {
+class IOBuffer;
+}
+
+namespace content {
+
+class ResourceController;
+class Stream;
+class StreamRegistry;
+
+// StreamWriter is a helper class for ResourceHandlers which route their output
+// into a Stream. It manages an internal buffer and handles back-pressure from
+// the Stream's reader.
+class StreamWriter : public StreamWriteObserver {

[mmenke, 2014/10/15 20:05:44]

Hrm...  This naming is really unfortunate.  Sounds like it watches itself... 
And then the Stream has a writer_ member, which is not this, but what the stream
writes to.  Making this more of a Stream's ByteStreamWriter Writer...Somehow,
though, StreamByteStreamWriterWriter doesn't seem like much of an improvement.

+ public:
+  // Creates a new StreamWriter without an initialized Stream or controller. The
+  // controller must be set before the writer is used.
+  StreamWriter();
+  virtual ~StreamWriter();
+
+  Stream* stream() { return stream_.get(); }
+
+  void set_controller(ResourceController* controller) {
+    controller_ = controller;
+  }
+
+  // Initializes the writer with a new Stream in |registry|. |origin| will be
+  // used to construct the URL for the Stream. See WebCore::BlobURL and and
+  // WebCore::SecurityOrigin in Blink to understand how origin check is done on
+  // resource loading.
+  void InitializeStream(StreamRegistry* registry,
+                        const GURL& origin);

[mmenke, 2014/10/15 20:05:44]

nit:  Do these fit on one line?

+
+  // Prepares a buffer to read data from the request. This call will be followed
+  // by either OnReadCompleted (on successful read or EOF) or destruction.  The
+  // buffer may not be recycled until OnReadCompleted is called. If |min_size|
+  // is not -1, it is the minimum size of the returned buffer.
+  //
+  // OnWillRead may be called before the stream is initialized. This is to
+  // support BufferedResourceHandler which reads the initial chunk of data
+  // early.
+  void OnWillRead(scoped_refptr<net::IOBuffer>* buf,
+                  int* buf_size,
+                  int min_size);
+
+  // A read was completed, forward the data to the Stream. If |*defer| is set to
+  // true, the implementation must not continue to process the request until
+  // Resume is called on |controller_|.
+  //
+  // InitializeStream must have been called before calling OnReadCompleted.
+  void OnReadCompleted(int bytes_read, bool* defer);
+
+  // Called when there is no more data to read to the stream.
+  void Finalize();
+
+ private:
+  // StreamWriteObserver implementation.
+  virtual void OnSpaceAvailable(Stream* stream) override;
+  virtual void OnClose(Stream* stream) override;

[mmenke, 2014/10/15 20:05:44]

I think the new hotness is to use override without the virtual?

+
+  ResourceController* controller_;
+  scoped_refptr<Stream> stream_;
+  scoped_refptr<net::IOBuffer> read_buffer_;
+
+  DISALLOW_COPY_AND_ASSIGN(StreamWriter);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_LOADER_STREAM_WRITER_H_